From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5D31541C5DC
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 19 Jun 2020 20:30:17 +0300 (MSK)
References: <cover.1592482315.git.sergepetrenko@tarantool.org>
 <c019cb4048fc6cf26c4b5c9f0ac80ae0e0fa96d6.1592482315.git.sergepetrenko@tarantool.org>
 <20200618144653.GR134822@grain>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <7e0d163b-b15e-5061-71ea-4a7171cf52e9@tarantool.org>
Date: Fri, 19 Jun 2020 20:30:16 +0300
MIME-Version: 1.0
In-Reply-To: <20200618144653.GR134822@grain>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 2/4] xrow: add ability to
	encode/decode ROLLBACK requests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org


18.06.2020 17:46, Cyrill Gorcunov пишет:
>> diff --git a/src/box/xrow.c b/src/box/xrow.c
>> index 896e001b7..7a79a18dd 100644
>> --- a/src/box/xrow.c
>> +++ b/src/box/xrow.c
>> @@ -879,7 +879,8 @@ xrow_encode_dml(const struct request *request, struct region *region,
>>   }
>>   
>>   int
>> -xrow_encode_confirm(struct xrow_header *row, uint32_t replica_id, int64_t lsn)
>> +xrow_encode_confirm_rollback(struct xrow_header *row, uint32_t replica_id,
>> +			     int64_t lsn)
>>   {
> Should not it be a static function?


I agree, thanks for noticing!

Fixed.

-- 
Serge Petrenko