From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 114556D6B99; Thu, 9 Nov 2023 10:06:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 114556D6B99 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699513591; bh=MMWQmdcjiumhNvx1svlKlyVPlTI7qUf/MftizaavO10=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wdn0XOx5ty+RuHhYhrSVX+7INOCI+V6aGvroWKttGzWbUlbly/6pWT2pwCpotOjEw Yzcm9aH3Aksc13oIKj9EqJUEWKbJal3m7+QWxRGAiYNvjpyDqVhQDPZB3fhRrz5VRc 36rdx6kMdgvkA0qABqeGBx/Lp9jPosgop1k3vcLc= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4F61D6B33EB for ; Thu, 9 Nov 2023 10:06:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4F61D6B33EB Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1r0z7U-00C6PO-1g; Thu, 09 Nov 2023 10:06:28 +0300 Message-ID: <7cfd987c-2740-42bb-9f45-730e8bbc9352@tarantool.org> Date: Thu, 9 Nov 2023 10:06:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin References: <20230710122818.22221-1-m.kokryashkin@tarantool.org> <9aec4ca0-09c0-2692-81e6-5d391f06fd7b@tarantool.org> <1689345019.547057052@f380.i.mail.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9C2A6B03AB739174CF58A37BEEF658239A457191693789A1900894C459B0CD1B9ADA0AF47D4A7871CA679873324FAFA4FF3AA16F3C05FCD376C140D91676DDD80 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063715F166F2542EEE4C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83E3D6214A5429D3651EE19BE0CF6A852117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC292D688DDAD4E7BC389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8ED96AA85C75E140D117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF0E073B7150C52A2EBA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B60F784CBF0D2551B676E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C224936DA1BED736F9328E827F84554CEF50127C277FBC8AE2E8BF1175FABE1C0F9B6AAAE862A0553A39223F8577A6DFFEA7C3DDF88F19B2F251A43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5D633F50646E30FDC47AC38EB49BC4FCACA7E950404D83397F87CCE6106E1FC07E67D4AC08A07B9B065B78C30F681404DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFEB5C4A28478E9A7FA6DFE1113F6E0E6D3BF7BD1CCFEB78842CB6969B1F00463C45F8ED8E1771A93D2B33B16BC67043E0E05720DFD7A40BE6EF15D4E093293381A74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKdAcnY08CHLDGn/SQSNNAw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769D35593852401E0FDCDE9D410387BE9509BBFB9D4C9B76856EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max On 11/9/23 02:01, Maxim Kokryashkin wrote: > Hi! > Thanks for the review! > Fixed your comment, branch is force-pushed. Diff is below: > === > diff --git a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua > index 347bd087..90a19156 100644 > --- a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua > +++ b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua > @@ -48,6 +48,6 @@ end > res, err = misc.sysprof.stop() > assert(res, err) > > -test:ok(true, 'sysprof finished successfully') > +test:ok(true, 'FFUNC frames were streamed correctly') > > os.exit(test:check() and 0 or 1) > === > Thanks! LGTM as I said before