From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3BE5F45C304
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 16 Dec 2020 01:12:56 +0300 (MSK)
References: <cover.1607696813.git.lvasiliev@tarantool.org>
 <09684330fa61f01381f05bbbc0e49e567a8a14a7.1607696813.git.lvasiliev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <7cc08d39-0bb3-3ac5-f426-8d54d33c808b@tarantool.org>
Date: Tue, 15 Dec 2020 23:12:53 +0100
MIME-Version: 1.0
In-Reply-To: <09684330fa61f01381f05bbbc0e49e567a8a14a7.1607696813.git.lvasiliev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 1/3] sql: add missing diag_set on
 failure when working with files inside SQL module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>, imeevma@tarantool.org, korablev@tarantool.org, sergos@tarantool.org, m.semkin@corp.mail.ru
Cc: Mergen Imeev <imeevma@gmail.com>, tarantool-patches@dev.tarantool.org

Thanks for the fixes!

What about missing diag in robust_ftruncate()?

In findInodeInfo() you can get -1 from fstat().

unixFileLock() can return -1 from fcntl().

seekAndRead() and seekAndWriteFd() can return -1
from lseek() and read().

fcntlSizeHint() and unixMapfile() can return -1
from fstat().

unixGetTempname() can return -1, but I don't see if
it even sets errno.

getFileMode() can return -1 from stat().

unixDelete() can return -1 from unlink(), fstat()

I suggest to fix everything. It is all in one file and all
is related.