From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0536EBA2F35; Thu, 13 Jun 2024 18:14:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0536EBA2F35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718291682; bh=zlitTPq6SDJ0dv4koMuh3ZZ3U3/LY3mfUhDWvnuX66A=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BwnteKdw6K7wE3jbz9gfB37GsRaiB4Zn1/J6jkqfNZYhmuy1bHEBntToOJR4HQgNo kPTjsV3dAnEYw4J7/jdGqRdLM0RhvUb8t7wOO/iBZVh2+HrNxoadfpSHTdeZsxbHjZ uvSbV/VN3A/6d5sl0rJWoY7p+9Pj7Hfiokfdj5mk= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 21F26BA2F35 for ; Thu, 13 Jun 2024 18:14:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 21F26BA2F35 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1sHm9w-0000000CuEB-0q6k; Thu, 13 Jun 2024 18:14:40 +0300 Content-Type: multipart/alternative; boundary="------------CZdPuJVCCcV3n3Jgx0PhQRG1" Message-ID: <7c35c3d3-60fd-4d2b-abd7-556c26859208@tarantool.org> Date: Thu, 13 Jun 2024 18:14:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <034b0afe429e672809ec8192ff1fb41a7bfd2937.1717424008.git.skaplun@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9923B2AA154DF63C61EC445C97C7F2A689B9B2CF16763F2F11313CFAB8367EF908E2BE116634AD74D0A925F8458A0F1621EE0F1D5166E5A8C25252FC723FA160B5B3CE9A35406B3E72890F9C47E136152 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBB2043146276655EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B12C6B1582157D838638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C2FA1BCED09E5FA156E156892581BB9F2266751CBBBB1BCCCC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4E7D9683544204AF6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3B74263D4D5690889BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE74F0F518E68DBD4F843847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A540C4898A5A83644A5002B1117B3ED696E673B36384ECE80392B673A2F5DDD7E7823CB91A9FED034534781492E4B8EEADCAFEFF123806BC82BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3455049D7B43D89D6489ED1C0DABEA9970855C67712A5EEA7E41FC5E933C6F992F02CD5D3C198F05CA1D7E09C32AA3244C04048BE2F6223C884EB7DF677E51682D34178005CCDA7DA5EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP/c/PTD82AnnaJzYHnEktw== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61400A925F8458A0F1621EE0F1D5166E5A8C016BDB11049D896F0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/4] FFI: Allow ffi.metatype() for typedefs with attributes. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------CZdPuJVCCcV3n3Jgx0PhQRG1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.06.2024 10:34, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comment and force-pushed the branch. Thanks! LGTM as I said before. > > On 11.06.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> thanks for the patch! LGTM with a nit below. >> >> On 03.06.2024 17:34, Sergey Kaplun wrote: >>> From: Mike Pall >>> >>> Reported by Eric Gouyer. >>> >>> (cherry picked from commit 27a6fee82e91319bbed8c3aa443aa2b0f1b0a470) >>> >>> Before the patch, `ffi.metatype()` raises an error when calling it on >>> ctype with attributes. This patch fixes the behaviour by using >> extra whitespace above >>> `ctype_raw()` instead of `ctype_get()` to follow child ctypes unless >>> there are no attributes on the ctype. >>> >>> Sergey Kaplun: >>> * added the description and the test for the problem >>> >>> Part of tarantool/tarantool#9924 >>> --- > > --------------CZdPuJVCCcV3n3Jgx0PhQRG1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 13.06.2024 10:34, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.
Thanks! LGTM as I said before. 

On 11.06.24, Sergey Bronnikov wrote:

Hi, Sergey

thanks for the patch! LGTM with a nit below.

On 03.06.2024 17:34, Sergey Kaplun wrote:

From: Mike Pall <mike>

Reported by Eric Gouyer.

(cherry picked from commit 27a6fee82e91319bbed8c3aa443aa2b0f1b0a470)

Before the patch, `ffi.metatype()` raises an error when calling it on
ctype with attributes.  This patch fixes the behaviour by using

extra whitespace above

`ctype_raw()` instead of `ctype_get()` to follow child ctypes unless
there are no attributes on the ctype.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#9924
---

<snipped>
--------------CZdPuJVCCcV3n3Jgx0PhQRG1--