From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E11496FC86; Wed, 24 Mar 2021 15:26:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E11496FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616588782; bh=MgYW8wWeNKUGXcJwNPJfesNjbFSFKEzTFlpW4UORc+k=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ctTcIVSgoXRhvZgeWUFxVebaTAdKpozfUks/+M3i1MgV3DMEl4LuYfQPfN67C+ono G2j5eYXW9wREzrgxz6Tkde0sTcRCFB0vHxaFMPahFtHbfPWUU/AFA4dSi+RxGHRGJP Zk+/0prXTRKMsd3LjWGk5gJQVsh/GB4tzXuFrpQM= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8791B70157 for ; Wed, 24 Mar 2021 15:24:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8791B70157 Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1lP2Yh-0004oK-UR; Wed, 24 Mar 2021 15:24:24 +0300 To: v.shpilevoy@tarantool.org, gorcunov@gmail.com Date: Wed, 24 Mar 2021 15:24:14 +0300 Message-Id: <7c3116c6a052a35ca940a7ddcda3b90346ac5088.1616588119.git.sergepetrenko@tarantool.org> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F19D4B90E2C0E110A6B701D7D268243E19182A05F5380850405869C91659B4D1C7A07E3EF094246F230BA83A43916831B3A5C20A7CEDEC8F98 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EB05B7739F1E6D56EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637174E2957C4CE0F938638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D84C6FE19F0A93CF5A7A4A8F0283E62ACA471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7CD927F63B2C6B631D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED629923F8577A6DFFEA7C2059237F47C255B9CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF5012EF20D2F80756B5F868A13BD56FB6657E2021AF6380DFAD18AA50765F79006372E808ACE2090B5E1C4224003CC836476EC64975D915A344093EC92FD9297F6718AA50765F7900637E52AE9B802B2390DA7F4EDE966BC389F395957E7521B51C24C7702A67D5C33162DBA43225CD8A89FCBE33A7817EDC1EF57739F23D657EF2BB5C8C57E37DE458B4C7702A67D5C3316FA3894348FB808DB48C21F01D89DB561574AF45C6390F7469DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D2F56182786FC36FB355D89D7DBCDD132 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C4C7A0BC55FA0FE5FC5F433A0BE06BC4655F94B47369822AD26113400A0CEA560BB1881A6453793CE9C32612AADDFBE061C61BE10805914D3804EBA3D8E7E5B87ABF8C51168CD8EBDB63AF70AF8205D7DCDC48ACC2A39D04F89CDFB48F4795C241BDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34ADE558D2B396DA7CB0229D17C2EE7957079BDA4EE7D48F9CAE339EBB48AA44EFDDA722661002C4F31D7E09C32AA3244C013DD559C735C3C3A8D4CB00B771D8B0A95CA90A1D8AC565927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXjhXhGERY7yL3fHT54yAvxq X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F86C523D0B3819F67E9573368020B0CC4CCA58C28836E88626424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 4/7] applier: remove excess last_row_time update from subscribe loop X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" applier->last_row_time is updated in applier_read_tx_row, which's called at least once per each subscribe loop iteration. So there's no need to have a separate last_row_time update inside the loop body itself. Part of #5566 --- src/box/applier.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/box/applier.cc b/src/box/applier.cc index 07e557a51..d53f13711 100644 --- a/src/box/applier.cc +++ b/src/box/applier.cc @@ -1256,7 +1256,6 @@ applier_subscribe(struct applier *applier) struct stailq rows; applier_read_tx(applier, &rows); - applier->last_row_time = ev_monotonic_now(loop()); /* * In case of an heartbeat message wake a writer up * and check applier state. -- 2.24.3 (Apple Git-128)