From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 86D30144EDB1; Mon, 21 Jul 2025 15:21:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 86D30144EDB1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1753100460; bh=Khz/w8tDSGxrnbnDW+APuL1K88U6D6fzKqYPemmVG6s=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cIw7eF2i9KPfW4NEkbfUVOwdI6JpxRWb4rqHFnC5QF9TQGnBYCTe8U/aBmpq+26Sm OlXo+ydVCO0WOcg1PZRZIvXYC0K9lQ7M/LQrGF6bUdTUj8CiqNA8frgmtoXQ0x6N4J 2YXuyUyg3XAyX7nGcfy1r8qZbM3QLap5/U3coJ7g= Received: from send277.i.mail.ru (send277.i.mail.ru [95.163.59.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 04A81144EDB1 for ; Mon, 21 Jul 2025 15:20:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 04A81144EDB1 Received: by exim-smtp-6db95c9866-qzpg8 with esmtpa (envelope-from ) id 1udpVp-000000006QQ-49xh; Mon, 21 Jul 2025 15:20:58 +0300 Content-Type: multipart/alternative; boundary="------------o9ooQJrKEn3KhaSnQMiCum3Z" Message-ID: <7c148026-9ddc-4b6e-898a-b84c170c0eb2@tarantool.org> Date: Mon, 21 Jul 2025 15:20:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20250721081627.4837-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: <20250721081627.4837-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9B9F43B9EFA5FD564DFB483FBF9C61BFED8560ECFCD540BCF182A05F538085040CA2B7DABE58C3BB33DE06ABAFEAF6705875CF5055A9CF74D290BE10E18931E6E32F1CFC60563ED00 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566EBA330160BAF42EE292653EA83D41F1AF60F0A88FF703877B906C3F15B7A5FB4389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C091DAD9F922AA71188941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E232F00D8D26902CA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCC2ED6D5310B1F811D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7B742A0F936AD8A56CD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A496CF6352268F95089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5609CD2B576B0AB4C5002B1117B3ED696CB38E9E1958C11268B25839F35DFE037823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFEFA979E3EF8A47A9240D6734C2BF1074D2E033F611E9E9E3C1C233E88970FAA2124E09ADABDE4174B22A61435000626E74A1419B460D4F84A429C87592928E77EAEDD958624D36A2111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVU4HtwWQGdJGrH51tZoxa7g= X-Mailru-Sender: 4C2B2EA4912B1EDDF1101D80EC0F15126016B67056AA03F63DE06ABAFEAF6705875CF5055A9CF74DB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------o9ooQJrKEn3KhaSnQMiCum3Z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Sergey, thanks for the patch! > [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64 s/or/on/? On 7/21/25 11:16, Sergey Kaplun wrote: > The test may lead to the assertion failure if run under Tarantool. > Also, the skip condition for the Tarantool leads to stable fails for > some builds on x86/x64 architecture, so they are skipped as well. > See details in the comment to the skip conditions. > --- I suppose you want to disable it temporarily, do we need an issue as a reminder? LGTM > > Branch:https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool > > Originally I want to disable the test only for Tarantool, but faced > multiple failures in the different workflows: > https://github.com/tarantool/luajit/actions/runs/16410069543 > > .../lj-1196-partial-snap-restore.test.lua | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua b/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua > index 4ab78d31..5199ca00 100644 > --- a/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua > +++ b/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua > @@ -4,7 +4,14 @@ local tap = require('tap') > -- in case of the stack overflow. > -- See also:https://github.com/LuaJIT/LuaJIT/issues/1196. > > -local test = tap.test('lj-1196-partial-snap-restore') > +local test = tap.test('lj-1196-partial-snap-restore'):skipcond({ > + -- Disable test for Tarantool to avoid failures, see also: > + --https://github.com/LuaJIT/LuaJIT/issues/1369. > + ['Disabled for Tarantool due to lj-1369'] = _TARANTOOL, > + -- Also, it may fail on some non-arm64 runners stable after > + -- adding the skip condition above. > + ['Disabled for x86/x64 due to lj-1369'] = jit.arch ~= 'arm64', > +}) > > test:plan(1) > --------------o9ooQJrKEn3KhaSnQMiCum3Z Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hello, Sergey,

thanks for the patch!

> [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64

s/or/on/?

On 7/21/25 11:16, Sergey Kaplun wrote:
The test may lead to the assertion failure if run under Tarantool.
Also, the skip condition for the Tarantool leads to stable fails for
some builds on x86/x64 architecture, so they are skipped as well.
See details in the comment to the skip conditions.
---

I suppose you want to disable it temporarily, do we need an issue as a reminder?

LGTM

Branch: https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool

Originally I want to disable the test only for Tarantool, but faced
multiple failures in the different workflows:
https://github.com/tarantool/luajit/actions/runs/16410069543

 .../lj-1196-partial-snap-restore.test.lua                | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua b/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua
index 4ab78d31..5199ca00 100644
--- a/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua
+++ b/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua
@@ -4,7 +4,14 @@ local tap = require('tap')
 -- in case of the stack overflow.
 -- See also: https://github.com/LuaJIT/LuaJIT/issues/1196.
 
-local test = tap.test('lj-1196-partial-snap-restore')
+local test = tap.test('lj-1196-partial-snap-restore'):skipcond({
+  -- Disable test for Tarantool to avoid failures, see also:
+  -- https://github.com/LuaJIT/LuaJIT/issues/1369.
+  ['Disabled for Tarantool due to lj-1369'] = _TARANTOOL,
+  -- Also, it may fail on some non-arm64 runners stable after
+  -- adding the skip condition above.
+  ['Disabled for x86/x64 due to lj-1369'] = jit.arch ~= 'arm64',
+})
 
 test:plan(1)
--------------o9ooQJrKEn3KhaSnQMiCum3Z--