From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A246C15D1117; Mon, 17 Nov 2025 17:09:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A246C15D1117 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763388575; bh=qcqE5eLar/Txrw9R4WBxCrHtJdxxY3bkokp6ZNUHBQk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=l5VCbeW2yowI4j2DCPHmrrNsGslYNkLRWL5Gy3OHCM3J5mAuschfXDbiT4fJ4HVjX CWNyyjb7kABExQF00Wn7QuYoKNOpiTXReGShxNS3pmZD34zaTNCaRPn6U9wxUQwXZz pCUchPCdJViKg0AZw0dm4+5MeZ7sAhix7mQ7oOHI= Received: from send106.i.mail.ru (send106.i.mail.ru [89.221.237.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 04FC415D1117 for ; Mon, 17 Nov 2025 17:09:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 04FC415D1117 Received: by exim-smtp-88cf54d45-p4v44 with esmtpa (envelope-from ) id 1vKzvA-0000000021q-3l4G; Mon, 17 Nov 2025 17:09:33 +0300 Content-Type: multipart/alternative; boundary="------------8Y0leevJNUbNM95XKJeuQQNM" Message-ID: <7c057a87-fa2c-438d-a23e-565ded380109@tarantool.org> Date: Mon, 17 Nov 2025 17:07:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <8e4f2e3c75383cd06374e2e4ff1fcd8b6deba4d6.1761301736.git.skaplun@tarantool.org> In-Reply-To: <8e4f2e3c75383cd06374e2e4ff1fcd8b6deba4d6.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D1605FE00F9132C87FE67EE782B408ED083182A05F5380850409CABA0035C1FF0FE3DE06ABAFEAF6705438C5128DFA6FB1F61C9E0771A6A769C0168CBECDA868FB9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74B7EDB5828CF9C27EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063745476ED688D943148638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B20BA158C29325FEA52E070BE324C7D3C482138875233F7931F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0CAB4775CB929E3BB7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1F41620B44FB51B7DB3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BC6A536F79815AD9275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A58C75C2ADAF4FF1C25002B1117B3ED6961EF39324A7C4AF82219207EC0A953D2C823CB91A9FED034534781492E4B8EEADEEA082C9A12FE455BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D9DC20663B80603FD837A2573B928F2F8791628AF585CAA904C356A6BBD5FE76334A7E24BC83E93B1D7E09C32AA3244CC2B5D47F140D462277DD89D51EBB77427BF8E4742DA82788EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW162WT9iEQlvc= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59DDDEA8B845EDD0D43DE06ABAFEAF6705438C5128DFA6FB1FB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 30/41] perf: adjust scimark-lu in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------8Y0leevJNUbNM95XKJeuQQNM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, thanks for the patch! LGTM with a minor comment. I propose to add a small description to the comment. Something like this: The test runs a part of the Lua version of SciMark 2.0a, which is a benchmark for scientific and numerical computing developed by programmers at the NIST (National Institute of Standards and Technology). This test is made up of  dense LU matrix factorization benchmarks. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > Checks are omitted since they were not present in the original suite, > plus the precise result value depends on the input parameter. > --- > perf/LuaJIT-benches/scimark-lu.lua | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/perf/LuaJIT-benches/scimark-lu.lua b/perf/LuaJIT-benches/scimark-lu.lua > index 7636d994..4f521e0b 100644 > --- a/perf/LuaJIT-benches/scimark-lu.lua > +++ b/perf/LuaJIT-benches/scimark-lu.lua > @@ -1 +1,19 @@ > -require("scimark_lib").LU(100)(tonumber(arg and arg[1]) or 5000) > +local bench = require("bench").new(arg) > + > +local cycles = tonumber(arg and arg[1]) or 5000 > + > +local benchmark > +benchmark = { > + name = "scimark_lu", > + -- XXX: The description of tests for the function is too > + -- inconvenient. > + skip_check = true, > + payload = function() > + local flops = require("scimark_lib").LU(100)(cycles) > + benchmark.items = flops > + end, > +} > + > +bench:add(benchmark) > + > +bench:run_and_report() --------------8Y0leevJNUbNM95XKJeuQQNM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

thanks for the patch! LGTM with a minor comment.

I propose to add a small description to the comment. Something like this:

The test runs a part of the Lua version of SciMark 2.0a, which is a benchmark for scientific and numerical computing developed by programmers at the NIST (National Institute of Standards and Technology). This test is made up of  dense LU matrix factorization benchmarks.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
 perf/LuaJIT-benches/scimark-lu.lua | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/perf/LuaJIT-benches/scimark-lu.lua b/perf/LuaJIT-benches/scimark-lu.lua
index 7636d994..4f521e0b 100644
--- a/perf/LuaJIT-benches/scimark-lu.lua
+++ b/perf/LuaJIT-benches/scimark-lu.lua
@@ -1 +1,19 @@
-require("scimark_lib").LU(100)(tonumber(arg and arg[1]) or 5000)
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 5000
+
+local benchmark
+benchmark = {
+  name = "scimark_lu",
+  -- XXX: The description of tests for the function is too
+  -- inconvenient.
+  skip_check = true,
+  payload = function()
+    local flops = require("scimark_lib").LU(100)(cycles)
+    benchmark.items = flops
+  end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()
--------------8Y0leevJNUbNM95XKJeuQQNM--