From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 105C12DB37 for ; Mon, 29 Oct 2018 13:31:47 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ywn_FLMTJrfD for ; Mon, 29 Oct 2018 13:31:46 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BBDCD2DA82 for ; Mon, 29 Oct 2018 13:31:46 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v7 1/2] sql: return all generated ids via IPROTO References: <3ec6ee67-ed51-9fe6-4165-45c6062389a9@tarantool.org> From: Imeev Mergen Message-ID: <7b9e4f82-2eee-9dbc-1a93-982c7ecad1aa@tarantool.org> Date: Mon, 29 Oct 2018 20:31:44 +0300 MIME-Version: 1.0 In-Reply-To: <3ec6ee67-ed51-9fe6-4165-45c6062389a9@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy , tarantool-patches@freelists.org Cc: "n.pettik" Hi! Thank you for review! My answer below. On 10/29/18 1:17 PM, Vladislav Shpilevoy wrote: > Hi! > > On 27/10/2018 15:43, imeevma@tarantool.org wrote: >> According to documentation some JDBC functions have an ability to >> return all ids that were generated in executed INSERT statement. >> This patch gives a way to implement such functionality. >> >> Closes #2618 >> --- > > Do not omit branch and issue name. > > Why did not you send the second commit? > > Now I see, that it would be better to split this commit > into 2 parts: factoring fiber_gc() out of txn_commit and > auto-generated ids. I did it already and force pushed on the > branch. > > But it appeared that tests fail with this reproduce > file: > > ========================= rep.yaml =========================== > > --- > - [sql/select-null.test.lua, memtx] > - [sql/errinj.test.lua, memtx] > - [sql/persistency.test.lua, memtx] > - [sql/errinj.test.lua, vinyl] > - [sql/gh-2929-primary-key.test.lua, vinyl] > - [sql/message-func-indexes.test.lua, vinyl] > - [sql/drop-table.test.lua, memtx] > - [sql/gh2808-inline-unique-persistency-check.test.lua, memtx] > - [sql/transitive-transactions.test.lua, memtx] > - [sql/max-on-index.test.lua, vinyl] > - [sql/iproto.test.lua, vinyl] > - [sql/checks.test.lua, vinyl] > - [sql/triggers.test.lua, memtx] > - [sql/gh-3199-no-mem-leaks.test.lua, memtx] > - [sql/savepoints.test.lua, vinyl] > - [sql/gh2808-inline-unique-persistency-check.test.lua, vinyl] > > ================================================================ > > python test-run.py --reproduce rep.yaml > > [001] Test failed! Result content mismatch: > [001] --- sql/gh-3199-no-mem-leaks.result    Thu Oct 25 22:58:31 2018 > [001] +++ sql/gh-3199-no-mem-leaks.reject    Mon Oct 29 13:12:35 2018 > [001] @@ -27,7 +27,7 @@ > [001]  ... > [001]  fiber.info()[fiber.self().id()].memory.used > [001]  --- > [001] -- 0 > [001] +- 4036 > [001]  ... > > It repeats both on your branch and on my force > pushed version. Please, fix. > This problem is described in issue 3732 https://github.com/tarantool/tarantool/issues/3732 I found that mentioned yaml produces the same error on current 2.1 branch. Due to this it was decided that issue 2618 shouldn't deal with the problem.