From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B86347030F; Fri, 15 Jan 2021 16:02:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B86347030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610715731; bh=bGPxIWi/gZXP1YDc0mUHakpMRb1AuQy+SfWbg9ZSa44=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AJUwEIbhbf6kA+XFME4uiJoOsuxwU0mf4QzbPKLUPE/Sw/fAmM05JforsviQNvdYh ywz0UWRyHEPlgTXSDkJzM0NPdckOlQqUTHAV1zbzGA/HQw5IpB5R9FrXqIKvCvr05N pwh/0lnzBIJmsTgQLQwkBE2m4wZPS6vNHC/F+K1I= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4F1B17030F for ; Fri, 15 Jan 2021 16:02:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4F1B17030F Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1l0Ojx-0001EH-EC; Fri, 15 Jan 2021 16:02:09 +0300 To: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org References: <82365527bf3aefe026e0c0e4d93f3acbb882391c.1610709207.git.sergeyb@tarantool.org> Message-ID: <7b55f7c7-56ac-e10f-bbcd-90b6d302f270@tarantool.org> Date: Fri, 15 Jan 2021 16:02:09 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD3008320BFA2F4C653BABCE9B72A1DEA600894C459B0CD1B9098C4063A640F6FE153B4D4723A0995C02587BF5ABB16BCDB7E140D37D564E50 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7624C4D757C4F5837EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378010A306A5B6F90A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6FD3D10E84685BD88C2C036C1BB2713031AB43173495B49B389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B97735402B2F6520CBB7417B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050F91ADC097FE2C3A08CE99E4F20BAF2718B3661434B16C20AC78D18283394535A975ECD9A6C639B01BC09775C1D3CA48CF0B8B320EE581A76035872C767BF85DA22EF20D2F80756B5F40A5AABA2AD3711975ECD9A6C639B01B78DA827A17800CE70AD1028CF10412FC43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FBC2A4A7A8370ED8B3C9F3DD0FB1AF5EB4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5E7464BA48D8F423BDB15EECD886E0DC40EB626676C4C4B9AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3451BBE684D17D722109B9DAEACFFB70E3FA236C52AB2C7633A1CDD0D666B113DE5D761E5B39B7451C1D7E09C32AA3244C43C3C3312300F472EBAD4A42128FFB0B95A9E0DC41E9A4CFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ6qpHh3Jl+0+Q== X-Mailru-Sender: 583F1D7ACE8F49BDF28A51E06CB90EC1CB28DB18F2C7403DA17D45A739B1FD9728FD07CAFA31757D823C4E0A9438D55D74690CA6451351EDEC462FDC9CAD1E11B969B486931C0B990F27244EEAA5B9A5AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] luacheck: fix warnings in test/box X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 15.01.2021 15:54, Sergey Bronnikov пишет: > Thanks for review! > > On 15.01.2021 15:39, Serge Petrenko wrote: >> >> >> 15.01.2021 14:22, sergeyb@tarantool.org пишет: >>> From: Sergey Bronnikov >>> >>> Follows up #5455 >>> --- >> >> Thanks for the  patch! >> LGTM. >> One question below. >> >> >>> test/box/gh-5304-insert_during_recovery.lua | 10 +++++----- >>>   test/box/gh-5304-replace_during_recovery.lua |  1 + >>>   2 files changed, 6 insertions(+), 5 deletions(-) >>> >>> diff --git a/test/box/gh-5304-insert_during_recovery.lua >>> b/test/box/gh-5304-insert_during_recovery.lua >>> index ac6eef342..c8b6c5cfb 100644 >>> --- a/test/box/gh-5304-insert_during_recovery.lua >>> +++ b/test/box/gh-5304-insert_during_recovery.lua >>> @@ -1,24 +1,24 @@ >>>   #!/usr/bin/env tarantool >>>   -function none(old_space, new_space) >>> +local function none(old_space, new_space) -- luacheck: ignore >> >> What's "luacheck: ignore" comment for? Haven't you fixed the warning >> already by introducing `local` ? >> > There are two warnings here. First one about global scope, that was > fixed with "local" and second one > > about unused parameters, that was suppressed by "luacheck: ignore". Ok, I see, thanks! > >>>   end >>>   -function trigger_replace(old_space, new_space) >>> +local function trigger_replace(old_space, new_space) -- luacheck: >>> ignore >>>       box.space.temp:replace({1}) >>>       box.space.loc:replace({1}) >>>   end >>>   -function trigger_insert(old_space, new_space) >>> +local function trigger_insert(old_space, new_space) -- luacheck: >>> ignore >>>       box.space.temp:insert({1}) >>>       box.space.loc:insert({1}) >>>   end >>>   -function trigger_upsert(old_space, new_space) >>> +local function trigger_upsert(old_space, new_space) -- luacheck: >>> ignore >>>       box.space.temp:upsert({1}, {{'=', 1, 4}}) >>>       box.space.loc:upsert({1}, {{'=', 1, 4}}) >>>   end >>>   -trigger = nil >>> +local trigger = nil >>>     if arg[1] == 'none' then >>>       trigger = none >>> diff --git a/test/box/gh-5304-replace_during_recovery.lua >>> b/test/box/gh-5304-replace_during_recovery.lua >>> index d6a7099ac..8b9a657af 100644 >>> --- a/test/box/gh-5304-replace_during_recovery.lua >>> +++ b/test/box/gh-5304-replace_during_recovery.lua >>> @@ -2,6 +2,7 @@ >>>     if arg[1] == 'replace' then >>>       box.ctl.on_schema_init(function() >>> +        -- luacheck: ignore >>>           box.space._index:on_replace(function(old_space, new_space) >>>               if new_space[1] == 512 then >>> box.space.test:on_replace(function(old_tup, new_tup) >> -- Serge Petrenko