From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A98AD46970E
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 27 Dec 2019 16:45:41 +0300 (MSK)
References: <cover.1576743850.git.imeevma@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <7af42017-edf4-30e3-8638-b83083330a69@tarantool.org>
Date: Fri, 27 Dec 2019 16:45:40 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1576743850.git.imeevma@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 0/3] Introduce _session_setting
	system view
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

LGTM.

On 19/12/2019 09:32, imeevma@tarantool.org wrote:
> This patch-set creates _session_settings system space. This space
> is used to view and change session settings.
> 
> https://github.com/tarantool/tarantool/issues/4511
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4511-new-engine
> 
> Mergen Imeev (3):
>   box: introduce 'virtual' engine
>   box: introduce _session_settings system space
>   box: add SQL settings to _session_settings
> 
>  src/box/CMakeLists.txt                             |   2 +
>  src/box/bootstrap.snap                             | Bin 5921 -> 5975 bytes
>  src/box/box.cc                                     |   4 +
>  src/box/lua/space.cc                               |   2 +
>  src/box/lua/upgrade.lua                            |  15 +
>  src/box/schema_def.h                               |   8 +
>  src/box/session_settings.c                         | 409 +++++++++++++++++++++
>  src/box/session_settings.h                         |  62 ++++
>  src/box/sql.h                                      |  47 +++
>  src/box/sql/build.c                                | 273 ++++++++++++++
>  src/box/sql/main.c                                 |   8 +
>  src/box/virtual_engine.c                           | 134 +++++++
>  src/box/virtual_engine.h                           |  55 +++
>  test/app-tap/tarantoolctl.test.lua                 |   4 +-
>  test/box-py/bootstrap.result                       |   3 +
>  test/box/access_sysview.result                     |   6 +-
>  test/box/alter.result                              |   5 +-
>  ...h-4511-access-settings-from-any-frontend.result | 275 ++++++++++++++
>  ...4511-access-settings-from-any-frontend.test.lua | 103 ++++++
>  test/wal_off/alter.result                          |   2 +-
>  20 files changed, 1409 insertions(+), 8 deletions(-)
>  create mode 100644 src/box/session_settings.c
>  create mode 100644 src/box/session_settings.h
>  create mode 100644 src/box/virtual_engine.c
>  create mode 100644 src/box/virtual_engine.h
>  create mode 100644 test/box/gh-4511-access-settings-from-any-frontend.result
>  create mode 100644 test/box/gh-4511-access-settings-from-any-frontend.test.lua
>