From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AD072469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 12 Feb 2020 01:17:30 +0300 (MSK)
References: <cover.1580841722.git.korablev@tarantool.org>
 <8e0dd524221265bfba1906e1bc6fb0608b1f0c45.1580841722.git.korablev@tarantool.org>
 <eee149e2-52be-6179-0f59-34c2beaac9a9@tarantool.org>
 <20200211141432.GA5708@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <7af1a58c-c315-7656-5930-ab1f33e19bfa@tarantool.org>
Date: Tue, 11 Feb 2020 23:17:29 +0100
MIME-Version: 1.0
In-Reply-To: <20200211141432.GA5708@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

I've pushed my review fixes on top of this commit. See it in the
end of the email, and on the branch.

3.2 and 3.13 still were the same, I dropped 3.13.

================================================================================

commit 6f1ce3265cab561c7d4959bd1a1998a986287da7
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date:   Tue Feb 11 23:14:48 2020 +0100

    Review fix

diff --git a/test/sql-tap/cast.test.lua b/test/sql-tap/cast.test.lua
index d4af339fd..fb0790d04 100755
--- a/test/sql-tap/cast.test.lua
+++ b/test/sql-tap/cast.test.lua
@@ -1,6 +1,6 @@
 #!/usr/bin/env tarantool
 test = require("sqltester")
-test:plan(80)
+test:plan(79)
 
 --!./tcltestrunner.lua
 -- 2005 June 25
@@ -682,11 +682,6 @@ test:do_execsql_test(
         -- </cast-3.12>
     })
 
-test:do_execsql_test(
-    "cast-3.13",
-    "SELECT CAST(9223372036854774800 AS NUMBER)",
-    {9223372036854774800LL})
-
 test:do_execsql_test(
     "cast-3.14",
     [[