From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A86706F3C7; Fri, 26 Mar 2021 02:51:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A86706F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616716319; bh=Mok0vbY0Oyrh8ltX3rlZmp9yTR9nNo9lA7JWaQjIEjE=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=heg1nkHbVq/a2eQBh9kf1NqfNZ8dYFU9GLI/w+NWAgamBVIlj8CkXId4O3dGDO9KT fxClddEQ0/aCsSP+Wm0EFTQAaAkGLjYGrEreJVfjS7DScWdp1WahI1vBywhMB5d1sB KjjrOMfj7EXK33NG7w1ivUNFGeD0z1TyYIlnkatk= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D26526F3C7 for ; Fri, 26 Mar 2021 02:51:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D26526F3C7 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lPZle-0000lc-Dw; Fri, 26 Mar 2021 02:51:58 +0300 To: Cyrill Gorcunov Cc: tml References: <20210324163759.1900553-1-gorcunov@gmail.com> <20210324163759.1900553-2-gorcunov@gmail.com> <8faa2e1e-c198-832d-d527-1acf2280720d@tarantool.org> <19605c5e-e96c-8580-6309-3b0e58df8c01@tarantool.org> Message-ID: <7aee215d-4a5a-1fba-bea1-510a5ced6287@tarantool.org> Date: Fri, 26 Mar 2021 00:51:57 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE919EF87AC0718675712B828C563C11F50182A05F53808504038BE622EE92F703F8107D94931809DF8C426BED00443098EBE9176C2D0A1205D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE701173C01F417A2A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371A00CE7BDCE207EB8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D6F35F1D5E7C84DECB699B176FDEF60D7A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7A6779F98BF527B7A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3329DC2EF12373DEA117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978319441048F577191AF0ECBE94767D537CD X-C1DE0DAB: 0D63561A33F958A5E2D37220CB5D5AA6B318D2FAB68475973A8DD0D45BB56E57D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455049D7B43D89D64719ACF84A849A41F246C3EA6A5E27CA0FDF4AB7E4A18F9261362EE4BF74E573A1D7E09C32AA3244C29930AA8E280FF224676DEC5BF9742D9E8FBBEFAE1C4874C729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAi4ycno5emTUg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638220A0DDA8E74B753D121E91B446F31DF8C3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 25.03.2021 22:02, Cyrill Gorcunov via Tarantool-patches wrote: > On Thu, Mar 25, 2021 at 08:59:53PM +0100, Vladislav Shpilevoy wrote: >>> static double >>> box_check_wal_cleanup_delay(void) >>> { >>> + const double MAX_TIMEOUT = TIMEOUT_INFINITY; >>> + const double MIN_TIMEOUT = 0.001; >> >> I am going to repeat it here from what I said verbally and >> in the chat - don't restrict the timeout. We never restrict >> any timeouts. TIMEOUT_INFINITY is not literally double inf >> value. It is just some huge but valid double value. User in >> his code can have a bigger definition of what is infinity. >> >> The same with the min. Why do you limit it from below? I don't >> see a single reason for doing so. Only reasons against that - >> it is inconsistent with the other timeouts we have, and might >> conflict with how each particular user understand the "minimal" >> timeout. > > Most important reason is an epsilon value on hw level, how many > users remember what exactly range the "machine zero" covers? I don't remember, and I don't see why should I really. What is the reason you ban 0.0009 but allow 0.001? This looks random and does not protect from anything. > Do we really want to allow precision close to nanoseconds? We allow double. Whatever precision it gives.