From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 25841130BB03; Fri, 28 Feb 2025 16:12:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25841130BB03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1740748348; bh=MvPF35lMxcI23rY5pHr59RIXz8A0j3Nhz41JVSIsNi8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=v5Z+TnFYIGRmhSKAtUB6rhAQ4pInxAKAK0P2Oo8hUqFEELTOmcG7N5H66tS0VUI2b J7Ki8xxjl+vbyjEW70Wyn/UluEwOmEKxLkwATDzzkej7c2cSWqUdo5yNw+DMiRSRFy gV+gklggWg1aSDX3BH7m/zFPtI3For1wGX9juznI= Received: from send197.i.mail.ru (send197.i.mail.ru [95.163.59.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 23D283A6957 for ; Fri, 28 Feb 2025 16:12:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 23D283A6957 Received: by exim-smtp-848fbd8fb5-frhcb with esmtpa (envelope-from ) id 1to0AD-000000008uz-0PVD; Fri, 28 Feb 2025 16:12:25 +0300 Content-Type: multipart/alternative; boundary="------------frkG0qk2a0TZxao05iCUHHw9" Message-ID: <7ac9026f-cf92-4a71-9af1-5e4dd2cef95c@tarantool.org> Date: Fri, 28 Feb 2025 16:12:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20250227091825.31081-1-skaplun@tarantool.org> <39e85beb-f956-4359-9a40-016d855b0aa1@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A2A28D6C22EE4403F72BE999420CB4FC7AF6C432485801D6182A05F5380850407E1E51F4FD7852393DE06ABAFEAF6705DDC3C0DEF5B97421D16BAE78D9CD0A70FC108E89ABB85EB9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73C871DD2182510D5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566A8C13161F55D2E8F853E5E63CE85E10FB3F2F6413AFF2F47120AF101C2F85453389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0CAB4775CB929E3BB7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1F41620B44FB51B7DB3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B81DF583BEE9BDE68EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A57D74EFB2FF13B6435002B1117B3ED696773DD6A12689BD3C3E67C18142C611B7823CB91A9FED034534781492E4B8EEAD85CCBA673D36D1A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AC632F0BE69382F3A0C8F7A8105961DB2A87563C7E64E325EFD7EAFE3EF4A004D0B4E6F782C2DC521D7E09C32AA3244C38A33C329161CB7377DD89D51EBB77421752222A333A4346EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQQG/FugD0/CzoXDnJ59q9k= X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140634655BE69933BB4C7A4B249DE6549FD399FD5F2BDCD35D80152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix fix-mips64-spare-side-exit-patching X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------frkG0qk2a0TZxao05iCUHHw9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, LGTM,  thanks! On 27.02.2025 19:05, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > > On 27.02.25, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! >> >> On 27.02.2025 12:18, Sergey Kaplun wrote: >>> The aforementioned test is flaky when run under Tarantool due to not >>> enough room for all traces. The flushing of all traces at the start and >>> collecting them solves the issue. >> Have you considered another options like increasing `maxtrace` value? > We may also: > 1) Increase the maxtrace value (as you are asking) -- but this is fragile, > since the number of built-in traces inside the Tarantool may grow up > again, so we should continuously adjust it in the future. > 2) Disable the test for the Tarantool. Not so bad, but unnecessary -- > since we may make the test platform-independent. Ok, I got it. >>> The same issue may occur for the >>> , so it is adjusted as >>> well. >>> --- > > --------------frkG0qk2a0TZxao05iCUHHw9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

LGTM,  thanks!

On 27.02.2025 19:05, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!

On 27.02.25, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch!

On 27.02.2025 12:18, Sergey Kaplun wrote:

The aforementioned test is flaky when run under Tarantool due to not
enough room for all traces. The flushing of all traces at the start and
collecting them solves the issue.

Have you considered another options like increasing `maxtrace` value?

We may also:
1) Increase the maxtrace value (as you are asking) -- but this is fragile,
since the number of built-in traces inside the Tarantool may grow up
again, so we should continuously adjust it in the future.
2) Disable the test for the Tarantool. Not so bad, but unnecessary --
since we may make the test platform-independent.
Ok, I got it.

      

        

          
The same issue may occur for the
<gh-6098-fix-side-exit-patching-on-arm64.test.lua>, so it is adjusted as
well.
---


        

      

      
<snipped>



    

  
  


--------------frkG0qk2a0TZxao05iCUHHw9--