From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp10.mail.ru (smtp10.mail.ru [94.100.181.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E964C469710 for ; Sat, 6 Jun 2020 21:02:47 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <7a3dac5d-b4a6-a9b9-2f0e-076e46f6a38f@tarantool.org> Date: Sat, 6 Jun 2020 20:02:45 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 1/6] Add initial luacheck config List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, imun@tarantool.org Cc: alexander.turenko@tarantool.org Hi! Thanks for the patch! On 04/06/2020 10:39, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > config includes all files with Lua source code except: Lets start sentences from capital letters. > - third_party repositories > - directories with diff-based tests Seems like src/* is excluded. So nothing is checked, and the commit message is wrong. I see, that you turn on the checks in next commits, but then the commit message should be changed. > How-to check: > > $ luacheck --codes --config .luacheckrc . > > Part of #4681 > > Reviewed-by: Vladislav Shpilevoy > Co-authored-by: Vladislav Shpilevoy