From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4BECA2BAD4
	for <tarantool-patches@freelists.org>; Wed, 10 Apr 2019 20:02:49 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 68N8t0djwfAl for <tarantool-patches@freelists.org>;
	Wed, 10 Apr 2019 20:02:48 -0400 (EDT)
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 22C292BB0B
	for <tarantool-patches@freelists.org>; Wed, 10 Apr 2019 20:02:47 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v1 1/3] sql: remove legacy.c
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <e6682fc41a6a20ea0134c2e92e85c58446bfd21f.1554830037.git.imeevma@gmail.com>
Date: Thu, 11 Apr 2019 03:02:44 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <7FFBD0A8-A7CB-424F-A22F-DEEB1FB3A1E2@tarantool.org>
References: <cover.1554830037.git.imeevma@gmail.com>
 <e6682fc41a6a20ea0134c2e92e85c58446bfd21f.1554830037.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>


> @@ -1704,11 +1704,13 @@ sql_analysis_load(struct sql *db)
> 	info.db =3D db;
> 	info.stats =3D stats;
> 	info.index_count =3D 0;
> -	const char *load_stat1 =3D
> +	MAYBE_UNUSED const char *load_stat1 =3D
> 		"SELECT \"tbl\",\"idx\",\"stat\" FROM \"_sql_stat1\"";
> -	/* Load new statistics out of the _sql_stat1 table. */
> -	if (sql_exec(db, load_stat1, analysis_loader, &info, 0) !=3D 0)
> -		goto fail;
> +	/*
> +	 * Here was loading new statistics out of the _sql_stat1
> +	 * table using analysis_loader. This part of code was
> +	 * removed due to removal of sql_exec().
> +	 */

Which mechanism will replace this functionality?
Now I don=E2=80=99t see any alternatives. Personally I=E2=80=99d
remove this function on demand: when we
introduce replacement to analysis_loader().