From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C61B06F3C8; Tue, 4 Oct 2022 18:52:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C61B06F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1664898768; bh=CaH/NIGMh6IB4ObB1JDPTHECpZpdRygx17gdbmU2vCs=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=u/w5LRwQMPsk7W1G4vWDLMHdPDyydJZzh1FJ3EugXcECx5AqEmehzOX+5VeeowEZS i3EE/yEpC7oRMb1+LTU5fCNQJkfQMu7DyHWf6TeiXgHc3AF+5r2Cd1bkaWG77zOqYw ntG5hREpl3JAq5OBpi23YMLfR714r4mcCevB0Mto= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 70F066F3C8 for ; Tue, 4 Oct 2022 18:52:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 70F066F3C8 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1ofkDr-0003vj-PT; Tue, 04 Oct 2022 18:52:44 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) In-Reply-To: <465b76e54c06f083954f54f6394e1d79c8be5e48.1664207262.git.max.kokryashkin@gmail.com> Date: Tue, 4 Oct 2022 18:52:43 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <7D8963BA-643D-4FAD-A814-42CC4C02028F@tarantool.org> References: <465b76e54c06f083954f54f6394e1d79c8be5e48.1664207262.git.max.kokryashkin@gmail.com> To: Maksim Kokryashkin X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9EA63AAA3C7549E8E179405D11837770A83BA36D4E67A0A0700894C459B0CD1B9B4DE7BA35D9440875E7F15A5CD0E6B73B5A61BB082B6A1B818FB9CDCE596FCA9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85EC5F876C5C4F0336C8FC68212124B35117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC206EB891B201A04DA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE91ADC097FE2C3A08C8623B8F170C382FD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD0E433DBF1FBFA36136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344A2E3AE0A8792E69E1B5992A029F0A9A53D16343AA413DD2A02F0A45552BB9BEDC404C46546C824A1D7E09C32AA3244C243EF5578C894357F094FB40BA682384F165894D92D62706FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoN03fZs/02NXONTD+lousg== X-Mailru-Sender: 5AA3D5B9D8C486465A7E7C48E78B605D92D9B70D4268C461384FFF4FAB14717FD38A1BEA64D5C64A60D8632BEC246C7D55B4A2144138A8805FC805B5969CB4993EE16157CC7DAB4272D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/6] OSX/ARM64: Disable unwind info. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sergos via Tarantool-patches Reply-To: sergos Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! Just one nit. LGTM. Sergos > On 26 Sep 2022, at 18:55, Maksim Kokryashkin = wrote: >=20 > From: Mike Pall >=20 > See LuaJIT/LuaJIT#698. >=20 > (cherry picked from commit 78350a2565e1cf1102bcd25be406f02953d4dd3b) >=20 > External unwinding support is already disabled for OSX on ARM64 > platfrom so there is no point in generation of incorrect unwind s/platfrom/platform/ > info for it. This patch disables that generation. >=20 > Maxim Kokryashkin: > * added the description for the problem >=20 > Needed for tarantool/tarantool#6096 > Needed for tarantool/tarantool#7230 > --- > src/vm_arm64.dasc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/src/vm_arm64.dasc b/src/vm_arm64.dasc > index ad57bca3..ccfa72bd 100644 > --- a/src/vm_arm64.dasc > +++ b/src/vm_arm64.dasc > @@ -3990,7 +3990,8 @@ static void emit_asm_debug(BuildCtx *ctx) > ".LEFDE3:\n\n", (int)ctx->codesz - fcofs); > #endif > break; > -#if !LJ_NO_UNWIND > + /* Disabled until someone finds a fix. See #698. */ > +#if !LJ_NO_UNWIND && 0 > case BUILD_machasm: { > #if LJ_HASFFI > int fcsize =3D 0; > --=20 > 2.32.1 (Apple Git-133) >=20