From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E741D7030C; Fri, 5 Mar 2021 13:48:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E741D7030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614941286; bh=mKq6Hq0u5YhKQuxoH7IhqwXErfuFvs0xGNPFTfThw1c=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GY16fWHwdCdgjdJ4+4uYsKFymlzF9pttO1xY+h/FvlFsjvmzPHRpYXyCL8DieBGtc zshyD88+GdsgkEMHINWx0dL7LRqKhs/MTw1vSc8KMLwhwkAqesRiwbBvCfK4MNd49D gYCQjNIKb/fREAav6PQRmp3rd6Ua5gYs7tJZVknQ= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4D35A7030C for ; Fri, 5 Mar 2021 13:48:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D35A7030C Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1lI803-0002sX-Ka; Fri, 05 Mar 2021 13:48:03 +0300 Message-Id: <7D85A22A-0996-44F3-8748-06E409F27E6D@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_18ABC820-7DCB-413C-9BCE-2F26BFB238F2" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Fri, 5 Mar 2021 13:48:02 +0300 In-Reply-To: <20210304195821.GA745@root> To: Sergey Kaplun References: <68453AE4-8935-4717-A62C-957CDC0C8E13@tarantool.org> <20210304195821.GA745@root> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92A98208ECBDD29F5D8C0A06ED169F0586A18EBFAC8707E15182A05F538085040D6BD7D61385151E2B420825D097F22EAFD45B816CBBBA13880C8FA645FD49DE5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063745476ED688D943148638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC396D27D61463BD2C8EFA86FC9D3BD7F040D4AC0ABB7DDA1D389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC53A69B3AC30C7B9475ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735458315FA5AE40766C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F5D41B9178041F3E72623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5DB283C57E5E0ADD32BB9B21AD36679CFF32FB9F568FACE31D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D9DC20663B80603F71455A1667F46F32F642252972545DC7F540B80C51C6446EF197D89F2ED4797B1D7E09C32AA3244CB04B76EFB520E06E8B4D0E2C2ED87A6EE3D93501275E802FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXmjzTEesUQF6cEuOeTryeA== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81E853255709EFEAA45FB9E0A45F20CB68114DA969EB3B59FCDAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [WIP luajit 00/15] Adapt LuaVela test suites X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_18ABC820-7DCB-413C-9BCE-2F26BFB238F2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi! > On 4 Mar 2021, at 22:58, Sergey Kaplun wrote: >=20 > On 04.03.21, Sergey Ostanevich wrote: >> Hi! >>=20 >> Thanks for the patchset - brief review >>=20 >> part 1 - obvious, LGTM. >>=20 >> part 2 - LGTM, good to have all follow-ups set. >=20 > Do you mean to reference all follow-ups inside commit message? >=20 There could be just one - if no specific GH created. >>=20 >> part 3 - should have a follow-up ticket to cover all suppressions, if = we plan to fix them. >=20 > Ditto. > There are some follow ups that can be grepped by qa and luajit labels. >=20 And this is something I don=E2=80=99t want to do - to grep using lables. = The patch should have reference, so I can see all links at once. >>=20 >> part 4-8 are LGTM >>=20 >> part 9 (_G and some modules in Tarantool are different): Are we plan = to fix it in some way? There should be a follow-up then. >=20 > For now I can't see any good solution, except ignoring them by special > option like slow tests. >=20 I don=E2=80=99t object to ignore them. My question if we plan to tweak = the tests to align with Tarantool? What will happen to the test if Tarantool will change = preloaded modules? >>=20 >> parts 10-15 are LGTM >>=20 >> Regards, >> Sergos --Apple-Mail=_18ABC820-7DCB-413C-9BCE-2F26BFB238F2 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi!


On 4 Mar = 2021, at 22:58, Sergey Kaplun <skaplun@tarantool.org> wrote:

On 04.03.21, Sergey Ostanevich wrote:
Hi!

Thanks for the patchset - brief review

part 1 - obvious, LGTM.

part 2 - LGTM, good to have all follow-ups set.

Do you mean to reference all follow-ups inside commit = message?


There = could be just one - if no specific GH created.


part 3 - should have a follow-up ticket to cover all = suppressions, if we plan to fix them.

Ditto.
There are some follow ups that can be grepped by qa and = luajit labels.


And this is something I don=E2=80=99t want to do - to = grep using lables. The patch should
have reference, so I can = see all links at once.


part 4-8 are LGTM

part 9 (_G and = some modules in Tarantool are different): Are we plan to fix it in some = way? There should be a follow-up then.

For now I = can't see any good solution, except ignoring them by special
option like = slow tests.


I = don=E2=80=99t object to ignore them. My question if we plan to tweak the = tests to align
with Tarantool? What will happen to the test if = Tarantool will change preloaded
modules?


parts 10-15 are LGTM

Regards,
Sergos
= --Apple-Mail=_18ABC820-7DCB-413C-9BCE-2F26BFB238F2--