From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8CAE96EC40; Wed, 2 Jun 2021 15:28:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8CAE96EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622636920; bh=V03MsKBqGBVXEGswb3NCgnuNxWn4aj+ucZvU9d+PW8k=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yfWKhM89qL5HrBt087vsYe2nzS1KndgLlGCdZ18w2Fya76s0MS/5fRAoHAakh54+u Gm/NmZREJy65/epLEs3D4Bekv1Tq5XL59XELZzRxPCu670q5al08doyWQHs8PmabP6 Dar8QDg8HLZP+DLBCnwBydT3Ltbf3+r/vTBE+1j8= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 994A46EC40 for ; Wed, 2 Jun 2021 15:28:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 994A46EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1loPzB-0004Gh-OM; Wed, 02 Jun 2021 15:28:38 +0300 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: <703b21b49b4f5b04b71b322c25528eff4fb2d0e3.1621859367.git.skaplun@tarantool.org> Date: Wed, 2 Jun 2021 15:28:37 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <7D81109B-6734-42E4-914D-2567D1438BE4@tarantool.org> References: <703b21b49b4f5b04b71b322c25528eff4fb2d0e3.1621859367.git.skaplun@tarantool.org> To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C54EECC50CDFE52CD8E09EC742E3E75A787182A05F53808504045591C5D67AEE3BF7A1C622C3791B6BEA058D185408D486AE593CEE01E498CFB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75C385DEB91CEC222EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748744D4CD6EC491D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87C65FB70E42016B08007C5E720F980D5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6F7FD1A3A8AE6177F089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A59F6F91CFD9ED06C23A48D38697B4EC9483618425AEAA842CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FBC5FED0552DA851410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3433E9BC74ABA5769F25341A7B27E6D2B4D0494351A081FD440A05BC4F7FD5132F07DA584BB74131891D7E09C32AA3244C850AA3B60015A2DE50AD850FA995FEE1853296C06374E602FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+mfSpkNmA2rbQxPbM7VMzw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382211D7B8941B6A29095C22BF8E11135244D86460CE94ACC410B98B9A657DE05FA7FB559BB5D741EB96F714CF339B3F4B0DA5517EFC3E06706F67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] test: add skipcond on architectures for memprof X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! Just one fixup is needed. Sergos > On 24 May 2021, at 16:27, Sergey Kaplun wrote: >=20 > Memprof's tests fail for architectures different from x86 and x64, > because memprof is not yet implemented for them. >=20 > This patch adds skip condition to corresponding test. > --- > test/tarantool-tests/misclib-memprof-lapi.test.lua | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua = b/test/tarantool-tests/misclib-memprof-lapi.test.lua > index b4d66509..4df9cfd8 100644 > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > @@ -1,3 +1,9 @@ > +-- Memprof is implemented only for x86 and x64 architectures. ^^^^ =E2=80=94=E2=80=94> = ^ > +require("utils").skipcond( > + jit.arch ~=3D "x86" or jit.arch ~=3D "x64", I believe you overcomplicated the condition so it=E2=80=99ll skip even = for mentioned archs tarantool> x=3D'x86' --- ... tarantool> x~=3D'x86' or x~=3D'x64' --- - true ... > + jit.arch.." architecture is NIY for memprof" > +) > + > local tap =3D require("tap") >=20 > local test =3D tap.test("misc-memprof-lapi") > --=20 > 2.31.0 >=20