From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 88FDF278F8
	for <tarantool-patches@freelists.org>; Fri, 27 Jul 2018 07:40:24 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id UXiqKU2d32Es for <tarantool-patches@freelists.org>;
	Fri, 27 Jul 2018 07:40:24 -0400 (EDT)
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4849A20427
	for <tarantool-patches@freelists.org>; Fri, 27 Jul 2018 07:40:24 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH] sql: remove preupdate hook
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <b080f65ee9244937175bae9e4f628d54fc74627c.1532689276.git.kyukhin@tarantool.org>
Date: Fri, 27 Jul 2018 14:40:14 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <7D1DA51D-5B70-43C0-BA5D-1E3E497CF327@tarantool.org>
References: <b080f65ee9244937175bae9e4f628d54fc74627c.1532689276.git.kyukhin@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>

I have grepped and found few mentions about preupdate hook
which you didn=E2=80=99t delete.

Firstly, it seems that you can remove struct PreUpdate.
Secondly, one comment in update.c (line 565):

* That (regNew=3D=3DregnewPk+1) is true is also important for the
* pre-update hook. If the caller invokes preupdate_new(), the returned
* value is copied from memory cell (regNewPk+1+iCol), where iCol
* is the column index supplied by the user.

Remove it as well pls.