From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3105828991 for ; Fri, 9 Aug 2019 13:37:21 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mvPbROlbgStG for ; Fri, 9 Aug 2019 13:37:21 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7D7B9288C1 for ; Fri, 9 Aug 2019 13:37:20 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH v2 2/8] sql: GREATEST, LEAST instead of MIN/MAX overload From: "n.pettik" In-Reply-To: <7f7013d0209f432eb1ea12d897527ed9885c3599.1565275469.git.kshcherbatov@tarantool.org> Date: Fri, 9 Aug 2019 20:37:17 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <7C46701C-8D18-4433-9CD4-5B23FD6D7004@tarantool.org> References: <7f7013d0209f432eb1ea12d897527ed9885c3599.1565275469.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > On 8 Aug 2019, at 17:50, Kirill Shcherbatov = wrote: >=20 > The MIN/MAX functions are typically used only as aggregate > functions in other RDBMS(MSSQL, Postgress, MySQL, Oracle) while > Tarantool's SQLite legacy code use them also in meaning > GREATEST/LEAST scalar function. This must be fixed. So, basically this patch does two things: renames existing scalar min/max funcs and reserves names for them in NoSQL cache. Please, explicitly outline these facts in commit message. Also, I guess name change should be documented. > Moreover it is an important stem to get rid of function's name Nit: stem -> step. > overloading required for replace FuncDef cache with Tarantool's > function cache. > diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua > index 046eb3ee4..73b39332e 100644 > --- a/src/box/lua/upgrade.lua > +++ b/src/box/lua/upgrade.lua > @@ -910,6 +910,25 @@ local function upgrade_to_2_2_1() > create_func_index() > end >=20 > = +-------------------------------------------------------------------------= ------- > +-- Tarantool 2.2.2 > = +-------------------------------------------------------------------------= ------- > + > +local function upgrade_to_2_2_2() Does this patch come in scope of 2.2.2? I thought that it will be part of 2.3.1 (at least issues to be closed are related to 2.3). The rest is OK.