From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4B0D220EAF for ; Wed, 17 Jul 2019 12:18:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H1gRNhhvI_2n for ; Wed, 17 Jul 2019 12:18:51 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0C9BE24FA3 for ; Wed, 17 Jul 2019 12:18:50 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH 1/2] sql: remove "PRAGMA case_sensitive_like" From: "n.pettik" In-Reply-To: <1f34c8f1038ae55865745d041701c2193039c258.1563057282.git.roman.habibov@tarantool.org> Date: Wed, 17 Jul 2019 19:18:48 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <7BB8A4C9-226B-46F8-B330-12335CFE974F@tarantool.org> References: <1f34c8f1038ae55865745d041701c2193039c258.1563057282.git.roman.habibov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Roman Khabibov > On 14 Jul 2019, at 01:51, Roman Khabibov = wrote: >=20 > According to ANSI, LIKE should match characters taking into > account passed collation, so this pragma is no longer needed. Can=E2=80=99t build this particular patch: /Users/n.pettik/tarantool/src/box/sql/func.c:1795:1: error: conflicting = types for 'sql_is_like_func' sql_is_like_func(struct sql *db, struct Expr *expr, int *is_like_ci) ^ /Users/n.pettik/tarantool/src/box/sql/sqlInt.h:4277:1: note: previous = declaration is here sql_is_like_func(struct sql *db, struct Expr *expr); ^ /Users/n.pettik/tarantool/src/box/sql/func.c:1805:35: error: use of = undeclared identifier 'SQL_FUNC_CASE' *is_like_ci =3D (func->funcFlags & SQL_FUNC_CASE) =3D=3D 0; ^ 2 errors generated. make[2]: *** [src/box/sql/CMakeFiles/sql.dir/func.c.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [src/box/sql/CMakeFiles/sql.dir/all] Error 2 make: *** [all] Error 2 Please, fix compilation errors. > diff --git a/test/sql-tap/pragma.test.lua = b/test/sql-tap/pragma.test.lua > index 8221d36e6..d8fb550d0 100755 > --- a/test/sql-tap/pragma.test.lua > +++ b/test/sql-tap/pragma.test.lua > @@ -81,21 +81,16 @@ test:do_execsql_test( > -- > }) >=20 > --- Check that "PRAGMA case_sensitive_like" returns its status > --- (0 or 1) if called without parameter. > -test:do_test( > +-- Check that "PRAGMA case_sensitive_like" does not exist. > +test:do_catchsql_test( > "pragma-3.3", > - function() > - old_value =3D box.execute('PRAGMA = case_sensitive_like').rows > - box.execute('PRAGMA case_sensitive_like =3D 1') > - new_value =3D box.execute('PRAGMA = case_sensitive_like').rows > - box.execute('PRAGMA case_sensitive_like =3D '.. = old_value[1][1]) > - return new_value[1][1] > - end, > + [[ > + PRAGMA case_sensitive_like > + ]], { > -- > - 1 > + 1, "Pragma 'CASE_SENSITIVE_LIKE' does not exist" > -- > - ) > +}) Sorry, this test looks weird. Just remove it.