From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 007FF4696C3 for ; Fri, 10 Apr 2020 02:46:09 +0300 (MSK) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) From: Serge Petrenko In-Reply-To: <9a155caf-a790-7552-8671-8915506fd96e@tarantool.org> Date: Fri, 10 Apr 2020 02:46:08 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <7B489F40-4993-45AA-AFC9-5E87187014B5@tarantool.org> References: <9a155caf-a790-7552-8671-8915506fd96e@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/4] introduce indices over UUID List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org > 6 =D0=B0=D0=BF=D1=80. 2020 =D0=B3., =D0=B2 00:21, Vladislav Shpilevoy = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 > Hi! Thanks for the patchset! >=20 Hi! Thanks for the review! Please see my letters with answers to your comments, as well as v2 with = all the changes. > The build fails on your branch in Travis, on Linux with gcc: > = https://travis-ci.org/github/tarantool/tarantool/builds/670792910?utm_sour= ce=3Dgithub_status&utm_medium=3Dnotification I couldn=E2=80=99t fix the build yet, but I=E2=80=99m still sending out = the updated patchset so that you have more time to review it. I guess the build fix will be small enough, and I=E2=80=99ll update the = patchset again as soon as I manage to find what goes wrong. >=20 > On 04/04/2020 01:02, Serge Petrenko wrote: >> https://github.com/tarantool/tarantool/issues/4268 >> https://github.com/tarantool/tarantool/tree/sp/gh-4268-uuid-type >>=20 >> Serge Petrenko (4): >> decimal: fix comment typo >> uuid: expose additional from_string constructors >> box: add MsgPack encoding/decoding for UUID >> box: introduce indices by UUID >>=20 >> extra/exports | 3 + >> src/box/field_def.c | 66 +++++++++++--- >> src/box/field_def.h | 16 ++++ >> src/box/key_def.h | 3 +- >> src/box/tuple_compare.cc | 123 = +++++++++++++++++++++++++++ >> src/box/tuple_format.c | 3 +- >> src/lib/core/CMakeLists.txt | 1 + >> src/lib/core/mp_decimal.h | 2 +- >> src/lib/core/mp_extension_types.h | 2 + >> src/lib/core/mp_uuid.c | 75 ++++++++++++++++ >> src/lib/core/mp_uuid.h | 90 ++++++++++++++++++++ >> src/lib/core/mpstream.c | 11 +++ >> src/lib/core/mpstream.h | 5 ++ >> src/lib/msgpuck | 2 +- >> src/lib/uuid/tt_uuid.c | 9 ++ >> src/lib/uuid/tt_uuid.h | 53 +++++++++--- >> src/lua/msgpack.c | 27 ++++-- >> src/lua/msgpackffi.lua | 14 +++ >> src/lua/utils.c | 21 ++++- >> src/lua/utils.h | 5 ++ >> src/lua/uuid.lua | 9 -- >> test/app-tap/lua/serializer_test.lua | 8 ++ >> test/app-tap/msgpackffi.test.lua | 3 +- >> test/app/msgpack.result | 21 +++++ >> test/app/msgpack.test.lua | 13 +++ >> test/app/uuid.result | 2 +- >> test/box/tuple.result | 81 ++++++++++++++++++ >> test/box/tuple.test.lua | 25 ++++++ >> test/engine/ddl.result | 97 ++++++++++++++++++++- >> test/engine/ddl.test.lua | 42 ++++++++- >> test/engine/gh-4268-uuid.result | 58 +++++++++++++ >> test/engine/gh-4268-uuid.test.lua | 30 +++++++ >> test/unit/uuid.c | 24 +++++- >> test/unit/uuid.result | 8 +- >> third_party/lua-cjson/lua_cjson.c | 27 ++++-- >> third_party/lua-yaml/lyaml.cc | 17 +++- >> 36 files changed, 933 insertions(+), 63 deletions(-) >> create mode 100644 src/lib/core/mp_uuid.c >> create mode 100644 src/lib/core/mp_uuid.h >> create mode 100644 test/engine/gh-4268-uuid.result >> create mode 100644 test/engine/gh-4268-uuid.test.lua >>=20 -- Serge Petrenko sergepetrenko@tarantool.org