From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0D94627271 for ; Wed, 18 Jul 2018 04:31:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dUpa96GIbCsv for ; Wed, 18 Jul 2018 04:31:36 -0400 (EDT) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3FD92203CE for ; Wed, 18 Jul 2018 04:31:36 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: introduce TRUNCATE TABLE operation References: <70326bb69fbe25215df79e2d5e01043f93ff7c5a.1531902074.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: <797d52e5-1387-dd3d-1fb2-0fafbbbdcf56@tarantool.org> Date: Wed, 18 Jul 2018 11:31:33 +0300 MIME-Version: 1.0 In-Reply-To: <70326bb69fbe25215df79e2d5e01043f93ff7c5a.1531902074.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov Cc: korablev@tarantool.org Hello. I do not see, where do you call box_truncate, and where is a test that it is called. On 18/07/2018 11:22, Kirill Shcherbatov wrote: > As sql_table_delete_from already support OP_Clear fast cleanup > for non-complex requests we only need to introduce new words > to parser that call DELETE with NULL conditions. > > Closes #2201. > --- > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-2201-truncate-table > Issue: https://github.com/tarantool/tarantool/issues/2201 > > extra/mkkeywordhash.c | 1 + > src/box/sql/parse.y | 9 +++++++++ > test/sql/delete.result | 10 ++++++++++ > test/sql/delete.test.lua | 6 ++++++ > 4 files changed, 26 insertions(+) >