From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B573245C304
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Dec 2020 02:22:43 +0300 (MSK)
References: <20201203140446.66312-1-gorcunov@gmail.com>
 <20201203140446.66312-4-gorcunov@gmail.com>
 <4877abd0-72b4-57c0-a257-cf991ed8721a@tarantool.org>
 <20201208084823.GH2303@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <79130404-8280-cd06-6888-f8a2c53ad755@tarantool.org>
Date: Thu, 10 Dec 2020 00:22:42 +0100
MIME-Version: 1.0
In-Reply-To: <20201208084823.GH2303@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 3/3] test: add
 replication/gh-5446-sqync-eval-quorum.test.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, tml <tarantool-patches@dev.tarantool.org>

On 08.12.2020 09:48, Cyrill Gorcunov wrote:
> On Sat, Dec 05, 2020 at 12:52:25AM +0100, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> See 5 comments below.
>>
> 
> Here is a force-pushed update
> 
>  - I keep use explicit "start server replica1" which allows me
>    to grep update of quorum one by one
>  - I dropped unused space creation
>  - Raised number of repicas up to 6
>  - Since the patch is big i prefer to have it as a separate commit
> 
> It is unclear for me yet how to detect the replication failure
> when we would stop replica. Could you please help?

You try to make a synchronous transaction. If not enough replicas are
alive, the transaction will timeout.

I also ask you to add a test on what happens, when quorum formula is
changed while there are waiting transactions in the limbo. For example,
if I set the formula to return a smaller value than the current number
of alive replicas, the transactions should get committed.