From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 20998469719 for ; Sat, 15 Feb 2020 13:05:17 +0300 (MSK) From: Oleg Babin References: Message-ID: <78dc24fe-1b6e-b84d-3705-6f385e9db273@tarantool.org> Date: Sat, 15 Feb 2020 13:05:15 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/3] lua: table fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, imun@tarantool.org Cc: Oleg Babin Hi! Thanks for your comments! I asked Igor M. about this patchset and he said that final decision has not yet been made and patch with __pairs/__ipairs metamethods could be reverted. Then two my patches will not be needed. Therefore I will wait final decision. And I have a question about > Additionally, we have a new rule, that behaviour changing > tickets should be reflected in changelog. This ticket changes > behaviour. So you need to add a changelog label. Like this: Why I should get it from you but not from tarantool developers guide https://www.tarantool.io/en/doc/2.2/dev_guide/developer_guidelines/ ? On 14/02/2020 01:50, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > On 13/02/2020 21:33, olegrok@tarantool.org wrote: >> From: Oleg Babin >> >> This patchset fixes three problems. >> Two first are bugs in table.deepcopy function. >> The third is similar to the second >> (because the root of problem is a __pairs >> metamethod) that I found then worked on the >> second commit. >> >> Branch: https://github.com/tarantool/tarantool/tree/olegrok/table-fixes > > Usually we put issue number into branch name. Take a > look at branch list on GitHub for examples. > > Also you need to put web links at the affected issues > here. > > Additionally, we have a new rule, that behaviour changing > tickets should be reflected in changelog. This ticket changes > behaviour. So you need to add a changelog label. Like this: > > @ChangeLog > - table.deepcopy now correctly handles __metatable attribute of > a metatable (gh-4340). > > I was also thinking about adding a docbot request, but seems like > table.* extensions are not documented anyway. > >> >> Oleg Babin (3): >> lua: fix incorrect table.deepcopy __metatable handling >> lua: table.deepcopy ignores __pairs metamethod >> tap: is_deeply ignores __pairs metamethod >> >> src/lua/table.lua | 9 ++++++-- >> src/lua/tap.lua | 9 +++++--- >> test/app-tap/table.test.lua | 44 ++++++++++++++++++++++++++++++++++++- >> test/app-tap/tap.result | 6 +++-- >> test/app-tap/tap.test.lua | 24 +++++++++++++++++++- >> 5 files changed, 83 insertions(+), 9 deletions(-) >>