From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4574B12A8B14; Fri, 14 Mar 2025 13:53:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4574B12A8B14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1741949612; bh=Vxf9YcGbnrEaSKfxCLFF/SOOvVgPLbRYQgW/70vEO9E=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zCWUngf2fhz3ekA2uXJGKdlKECsgyPja5bLDiRO/E94kMpgII8H7HI1UnuGbeiVkK DDXAxQH4LGxs8X2VpgQoq6wB5mHKfjdg7z49fwsN7Z6j0lAosaSILU5EHMZPFppYJz 9q1Fk3rEAOL34JSngZbChVEmj0VnC+2AvBw70/1I= Received: from send243.i.mail.ru (send243.i.mail.ru [95.163.59.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AFB055BFC35 for ; Fri, 14 Mar 2025 13:53:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AFB055BFC35 Received: by exim-smtp-69cc44787d-28w5m with esmtpa (envelope-from ) id 1tt2fR-00000000AZu-2mld; Fri, 14 Mar 2025 13:53:30 +0300 Content-Type: multipart/alternative; boundary="------------m70WnOwM10DxVGvzOjABOsuP" Message-ID: <78d6b93d-5710-49cc-b13b-6feeb6b0720e@tarantool.org> Date: Fri, 14 Mar 2025 13:53:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <47c0d447e3d2a49da2678bf065da1a55eae0e9c3.1741617766.git.skaplun@tarantool.org> <21c40859-1aeb-4152-a5d6-4f82a4c8f5fe@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9CB00722163A93FBB5341C3CFB27ABD834B32BF74B4D1CA59CD62213F67905E7A6D7AB13195A0E560F5168D16EFAA40551FC63A028D5F6872F5D7D2BC6154D505DDDE7B70B5F5C79F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6759CC434672EE6371C2A783ECEC0211ADC4224003CC836476D5A39DEEDB180909611E41BBFE2FEB2B1F5E6E39434F10BCFCE5320B77C0205128B51A3E9CFAF123F26819059D687A699FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B292D688DDAD4E7BC389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006371C58C39218EE08BCD81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE70431F1D6FF51978FEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3AA8C68A3574AB3B435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5724211C4F8C0735F5002B1117B3ED696BE8886DE0688174B0E58516B1639A14B823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D75CEA0D7A80616E206503A9B8DCC87345C70DFB4B21C4DF9BEAFC6F741C183DFF5881AFDECA64A31D7E09C32AA3244CA72C56A6967D39F077DD89D51EBB77421B96264A1879EA8BEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQiWK+2I7Y2s5E/lVpEnNr4= X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61401632DA91C667226BC591814E25D11F9F5A0ABC55C9C25CBB0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] Fix state restore when recording __concat metamethod. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------m70WnOwM10DxVGvzOjABOsuP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, LGTM On 13.03.2025 13:28, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comment and force-pushed the branch. > > On 12.03.25, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! LGTM wit ha minor comment. >> >> Sergey >> >> On 10.03.2025 17:51, Sergey Kaplun wrote: >>> From: Mike Pall >>> >>> Reported by Sergey Kaplun. >>> >>> (cherry picked from commit eee16efa77b542e99c8e546a3d52fc023925c7bc) >>> >>> This commit is a follow-up to the previous one. It fixes the case when >>> the `topslot` is adjusting for simple concatenation results. This patch >>> adds the update of the corresponding Lua stack slots to be restored. >>> >>> This fixes back the test. >>> >>> Sergey Kaplun: >>> * added the description and the test for the problem >> It is partially true actually :) >> >> s/and the test// > Yes, the force of the habit (and copy-paste ;)) > >>> Part of tarantool/tarantool#11055 >>> --- > > --------------m70WnOwM10DxVGvzOjABOsuP Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

LGTM

On 13.03.2025 13:28, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 12.03.25, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch! LGTM wit ha minor comment.

Sergey

On 10.03.2025 17:51, Sergey Kaplun wrote:

From: Mike Pall <mike>

Reported by Sergey Kaplun.

(cherry picked from commit eee16efa77b542e99c8e546a3d52fc023925c7bc)

This commit is a follow-up to the previous one. It fixes the case when
the `topslot` is adjusting for simple concatenation results. This patch
adds the update of the corresponding Lua stack slots to be restored.

This fixes back the <lj-839-concat-recording.test.lua> test.

Sergey Kaplun:
* added the description and the test for the problem

It is partially true actually :)

s/and the test//

Yes, the force of the habit (and copy-paste ;))



        

          
Part of tarantool/tarantool#11055
---


        

      

      
<snipped>



    

  
  


--------------m70WnOwM10DxVGvzOjABOsuP--