From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BA6A5469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 14 Oct 2020 10:34:26 +0300 (MSK)
References: <cover.1602631481.git.v.shpilevoy@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <78d3e8bd-4217-a880-8e00-85890c33324c@tarantool.org>
Date: Wed, 14 Oct 2020 10:34:25 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1602631481.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 0/6] Raft auto-commit
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org


14.10.2020 02:28, Vladislav Shpilevoy пишет:
> The patchset implements Raft auto-commit feature, so when a new
> leader is elected, it clears the limbo queue after the old leader.
>
> There are 4 preparatory patches for that, and 1 follow-up not
> related to the auto-commit - the last commit fixes the issue 5395
> about a crash in the limbo, which started failing on every run of
> the tests now.
Hi! Thanks for the patchset!
LGTM.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5339-raft-auto-commit
> Issue: https://github.com/tarantool/tarantool/issues/5339
>
> @ChangeLog
> * When election is enabled, a newly elected leader will automatically finish all the synchronous transactions, created by the old leader (gh-5339).
>
> Vladislav Shpilevoy (6):
>    test: add '_stress' suffix to election_qsync test
>    raft: factor out the code to wakeup worker fiber
>    raft: new candidate should wait for leader death
>    raft: introduce on_update trigger
>    raft: auto-commit transactions of the old leader
>    qsync: reset confirmed lsn in limbo on owner change
>
>   src/box/box.cc                                |  42 ++++-
>   src/box/box.h                                 |   3 +-
>   src/box/lua/ctl.c                             |   2 +-
>   src/box/raft.c                                |  58 ++++--
>   src/box/raft.h                                |  13 ++
>   src/box/txn_limbo.c                           |   1 +
>   test/replication/election_qsync.result        | 177 ++++++++++--------
>   test/replication/election_qsync.test.lua      | 129 ++++++-------
>   test/replication/election_qsync_stress.result | 127 +++++++++++++
>   .../election_qsync_stress.test.lua            |  72 +++++++
>   test/replication/suite.ini                    |   2 +-
>   11 files changed, 460 insertions(+), 166 deletions(-)
>   create mode 100644 test/replication/election_qsync_stress.result
>   create mode 100644 test/replication/election_qsync_stress.test.lua
>
-- 
Serge Petrenko