From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3A69E6EC5B; Sat, 10 Apr 2021 02:55:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3A69E6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618012554; bh=7VwHKMSE30DFYWiv1vQ1V4Vy/DzMC1zBK9VHZAJNihQ=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OP7NfyqZWE4RWWV4hHBLXz+Jzj1kt2EEWEVur6NDCeghY5tKYEq3k45B4Wmb2/jaz DjTc93MJ3Todu2EWaImFnNv+4cddt+DZHFHpSmd5LFi0K2ElRU+hSrfu0rcKuSkcLY wtGC//oQWM4432Q549sISqNmlHxxBLhtrp7vhKXU= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 134026EC5B for ; Sat, 10 Apr 2021 02:55:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 134026EC5B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lV0ye-0003MU-3I; Sat, 10 Apr 2021 02:55:52 +0300 To: Cyrill Gorcunov , tml References: <20210408164151.1759348-1-gorcunov@gmail.com> <20210408164151.1759348-5-gorcunov@gmail.com> Message-ID: <78cb5dfc-5879-b307-c724-54a2f3e0dfac@tarantool.org> Date: Sat, 10 Apr 2021 01:55:50 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210408164151.1759348-5-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480B1C8842CE613979772AC4B34408C6525182A05F538085040670BB657C3B8D20F1FF35AEABE210EEFECAD19EDB323450A7C4100E2E81CD14F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74B51810D54EC17F0C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7FCFCB92DA8654BB0EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA65837F3DA25C1E0228E3724A68160D892E3F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22498424CA1AAF98A6958941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BC468E7E89D8C5D6EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783128B0E0BFFD1F556B916D7973594ED144 X-C1DE0DAB: 0D63561A33F958A51D7CEAAE1BFCB489CED6863F4C99EDE5F2413FA9035DD760D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3447DF5779098ECEE9888D23DB823D131B4E4C4800A0C43C3209A14D903DDF078FFA216117DFBF247C1D7E09C32AA3244C231FE92B32B7F8160A97F9B8B730D45C81560E2432555DBB927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqcJA+pXcDumpGlk0m+1FPA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822BFD5051DC011C79E79BADEBE2DA5476E3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v21 4/6] box/schema.func: switch to new module api X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Good job on the patch! The patch looks good, only one question below, like in the previous commit. > diff --git a/src/box/func.c b/src/box/func.c > index 10b916e6d..2cb111ba6 100644 > --- a/src/box/func.c > +++ b/src/box/func.c > @@ -188,240 +126,272 @@ schema_module_free(void) > { > while (mh_size(modules) > 0) { > mh_int_t i = mh_first(modules); > - struct module *module = > - (struct module *) mh_strnptr_node(modules, i)->val; > - /* Can't delete modules if they have active calls */ > - module_gc(module); > + mh_strnptr_del(modules, i, NULL); The same question as in the previous commit. Do we really need this loop now? > } > mh_strnptr_delete(modules); > + modules = NULL; > } I will review the next commits later.