From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imeevma@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2118F469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  9 Jun 2020 14:25:58 +0300 (MSK)
References: <cover.1590671266.git.imeevma@gmail.com>
 <0062fca6-8155-2c1b-dbb8-85d4afbb01cd@tarantool.org>
From: Mergen Imeev <imeevma@tarantool.org>
Message-ID: <78c4b11d-2500-0995-c08e-a737c7068da4@tarantool.org>
Date: Tue, 9 Jun 2020 14:25:56 +0300
MIME-Version: 1.0
In-Reply-To: <0062fca6-8155-2c1b-dbb8-85d4afbb01cd@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 0/6] Remove implicit cast
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tsafin@tarantool.org, tarantool-patches@dev.tarantool.org

Hi! Thank you for the review.

On 01.06.2020 20:03, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
>
> We need a changelog record here, with 'breaking change' label.
@ChangeLog
  - [Breaking change] Removed implicit cast from string to numbers
    and vice versa to addignment and to comparison.