From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B27552A69F for ; Fri, 22 Mar 2019 05:52:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t9zaiHIoBFer for ; Fri, 22 Mar 2019 05:52:51 -0400 (EDT) Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EEF3C293DA for ; Fri, 22 Mar 2019 05:52:50 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH v2 5/9] schema: add new system space for CHECK constraints From: "n.pettik" In-Reply-To: Date: Fri, 22 Mar 2019 12:52:46 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <78C56272-4459-4049-B817-AF3A4CB3CD0C@tarantool.org> References: <186b109d1f6049b1413fe0cdded43e5fad29a895.1548838034.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy , Kirill Shcherbatov > On 22 Mar 2019, at 12:29, Vladislav Shpilevoy = wrote: >=20 > Thanks for the patch! See 9 comments below. It is not a > complete review, because Kirill Y. said, that the patchset > is not finished (then why is it in the patches mailing list?). Patch-set itself is finished. I didn=E2=80=99t finished review of = patches starting from this one. FIrst 4 patches are barely related to check constraints. On the other hand, they contain fixes which turn out to be important for 2.1.1. (Idk what they are doing in current patch-set anyway).=