From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DFED22600E
	for <tarantool-patches@freelists.org>; Wed, 21 Aug 2019 16:42:24 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id QMVsXSKTPVzQ for <tarantool-patches@freelists.org>;
	Wed, 21 Aug 2019 16:42:24 -0400 (EDT)
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9695825CD1
	for <tarantool-patches@freelists.org>; Wed, 21 Aug 2019 16:42:24 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 2/3] txn: merge struct sql_txn
 into struct txn
References: <cover.1565190104.git.korablev@tarantool.org>
 <7d398281ec92e03c1d6f5f1bf93970debcfcc684.1565190104.git.korablev@tarantool.org>
 <f61b7549-121c-c516-7036-7a3ea6a1e61e@tarantool.org>
 <97A342BD-97BD-451F-A54B-A9CF18D352A3@tarantool.org>
 <b080e29d-2878-d30b-be88-db8d614542d4@tarantool.org>
 <D1974CF9-2539-423A-9448-1215963F5D12@tarantool.org>
 <de0f9b60-e565-02fc-5ac9-3444f8206489@tarantool.org>
 <3F4125D8-E07C-4FF9-A5D2-550C747BD2B4@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <78872b60-229c-1541-50e0-d1b596e61152@tarantool.org>
Date: Wed, 21 Aug 2019 22:45:22 +0200
MIME-Version: 1.0
In-Reply-To: <3F4125D8-E07C-4FF9-A5D2-550C747BD2B4@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>

Thanks for the fixes!

LGTM. Kirill, please, proceed. Also take a look at my
comment about backport below.

On 21/08/2019 02:23, n.pettik wrote:
> 
> 
>> On 19 Aug 2019, at 23:47, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote:
>>
>> Hi! Thanks for the fixes! Mine is in a separate commit
>> on the branch (after "txn: merge struct sql_txn into struct txn"),
>> and below. Please, squash if you are ok with that.
> 
> Yep, thanks, squashed.
> 
>> Talking of savepoint duplicate names - it is a bug existing in 2.2.1
>> too. I think, we should backport the fix. Or not. Up to Kirill.
>>