From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 126B21348C20; Thu, 6 Mar 2025 09:02:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 126B21348C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1741240925; bh=dLWgNcZWpHmR5zaz3R+xYJVWFk6vBUi1MJY4UMIpTzg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ysrbSoBqSguohuXmvqCaataPNbxefYtUbLTJiADUwSWWi3LXqi/1eU42hCbcnnjw5 kP2UxOTswTp5JZU1SgM8C/Xnj0e+ESgAEy5F2V9548Mu3YDkbpiZGKKgj/73ct5R7x U3fQb3p6jBZQZ7Umr7FJWi0wuW486AxKTjEfr+As= Received: from send276.i.mail.ru (send276.i.mail.ru [95.163.59.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DBF5D458A76 for ; Thu, 6 Mar 2025 09:02:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DBF5D458A76 Received: by exim-smtp-8cb569c79-58rjt with esmtpa (envelope-from ) id 1tq4Iw-00000000Ean-2C13; Thu, 06 Mar 2025 09:01:58 +0300 Content-Type: multipart/alternative; boundary="------------untE4KEiOTcNmC5xsHkSfU0o" Message-ID: <787240cb-842e-4094-a1fd-74f3f7398e94@tarantool.org> Date: Thu, 6 Mar 2025 09:01:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org References: <6f39b239-083c-4508-a364-1ba02b3b5ed3@tarantool.org> <7c01b6c6-36f0-45d4-acb8-d26577254796@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9C8AED3E6A44DB6ABFDCD53BBF41048049C796A527F736CF3182A05F538085040CE4D53DCA5EADD153DE06ABAFEAF67050518C8D0CA4AA77BF00ED21622D378876650089EE6ED7659 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F544D30F1A6FA191EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375666B3C118DAE8E67005FE4E68E43BB974B39A0BDE8A43C12A9DEF695C2AEEB998B389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6A70DDFFB3186CBC5CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249C90CCF169561558D76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B1058D73F572F8C9C3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D028CC0B556B22BCC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A598A7CD7FF2AD50C75002B1117B3ED696C09F629F98C9E4F203803A57F48E4E5A823CB91A9FED034534781492E4B8EEAD69BF13FED57427F1BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFF7C2EC92872EFEDB8DD07CE8DFB961ED6BC0F12349C27BEE08071AB841406D1F66401EE05C14F77DEDA8A7084F1AF318BD23C105DE0C4516D52F2C9295AB7A7AD10AA0A1D662596D5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQiWK+2I7Y2sMQ0kpfWPX48= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458CF6E54BC80894AAEDF237C39DF130474CDC75F589A85F5545A5E3B305626C841645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 8/8][v3] memprof: set default path to profiling output file X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------untE4KEiOTcNmC5xsHkSfU0o Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, On 05.03.2025 18:12, Sergey Kaplun wrote: >> >> >> +  res, err = misc.memprof.stop() >>    -- Want to cleanup carefully if something went wrong. >>    if not res then >> +test:fail('sysprof was not started: ' .. err) > Looks like it should be: "was not stopped successfully". Fixed, thanks! --- a/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua +++ b/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua @@ -26,7 +26,7 @@ test:test('default-output-file', function(subtest)    res, err = misc.memprof.stop()    -- Want to cleanup carefully if something went wrong.    if not res then - test:fail('sysprof was not started: ' .. err) + test:fail('sysprof was not stopped: ' .. err)      os.remove(default_output_file)    end >>      os.remove(default_output_file) >> -    error(err) >>    end >> >> + >>    local profile_buf = tools.read_file(default_output_file) >> subtest:ok(profile_buf ~= nil and #profile_buf ~= 0, >>               'default output file is not empty') >> >> -  -- We don't need it any more. >> +  -- We don't need it anymore. >>    os.remove(default_output_file) >>  end) >> > > > --------------untE4KEiOTcNmC5xsHkSfU0o Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

On 05.03.2025 18:12, Sergey Kaplun wrote:
<snipped>

+  res, err = misc.memprof.stop()
    -- Want to cleanup carefully if something went wrong.
    if not res then
+ test:fail('sysprof was not started: ' .. err)

Looks like it should be: "was not stopped successfully".

Fixed, thanks!

--- a/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua
+++ b/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua
@@ -26,7 +26,7 @@ test:test('default-output-file', function(subtest)
   res, err = misc.memprof.stop()
   -- Want to cleanup carefully if something went wrong.
   if not res then
-    test:fail('sysprof was not started: ' .. err)
+    test:fail('sysprof was not stopped: ' .. err)
     os.remove(default_output_file)
   end
 


      

        
      os.remove(default_output_file)
-    error(err)
    end

+
    local profile_buf = tools.read_file(default_output_file)
subtest:ok(profile_buf ~= nil and #profile_buf ~= 0,
               'default output file is not empty')

-  -- We don't need it any more.
+  -- We don't need it anymore.
    os.remove(default_output_file)
  end)



      

      
<snipped>




    

  
  


--------------untE4KEiOTcNmC5xsHkSfU0o--