From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B24A36ECCC; Tue, 9 Jun 2026 16:57:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B24A36ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1781013470; bh=ThHBYopqDLX+Z7rhU5+TVt7Qgute7ApxCOwejIaXt0M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZSZ0yWqv4vKQpwnhTBCmqsxLdGS4zmDH5mtHNxxs9vpGamNqhrhcSz+Ue8MsldZoA RXdh158XEtvrHYbp6Men7zJR2q8P8zboNvfwbYWGcx3hdSoaW9Ge8q1U9GGi6Y2foi WuohakpLcPXkTt6TCeet48hSbq/bic/R7V+29r4c= Received: from send127.i.mail.ru (send127.i.mail.ru [89.221.237.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4E3976ECCC for ; Tue, 9 Jun 2026 16:57:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E3976ECCC Received: by exim-smtp-5bf699dc9d-cj42f with esmtpa (envelope-from ) id 1wWwxg-000000002sk-1P2I; Tue, 09 Jun 2026 16:57:48 +0300 Content-Type: multipart/alternative; boundary="------------SmUuBKiIyaPOzSDjKYwJvwWJ" Message-ID: <78712f2b-739a-49fc-84d0-3449c6422bf6@tarantool.org> Date: Tue, 9 Jun 2026 16:57:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <20260604093052.2221827-1-skaplun@tarantool.org> <20260604093052.2221827-3-skaplun@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9E926CE86FFF978D75489016567BA443C67184CC39015D547182A05F538085040AD9982929B4794A93DE06ABAFEAF6705762404CBABC1E310600636CA48AE48DC84880BF194392199 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CF4D16325FBE1EEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756637AB5DC418F5BF140D1E5598B2E7FDFF283ACD33369072B6A1AB5212613F427D389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3A1C30C8AFC676C8B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5F676F90874B6CB425002B1117B3ED696ADC668A7CAB19956A13BD6A4B0E00B96823CB91A9FED034534781492E4B8EEADAE4FDBF11360AC9BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659044747141BCF3DCA6772AED37729B3B5FEE48F8D915C5150511668EC681800B46A558938A1871EFEB8341EE9D5BE9A0AAF1831E80BC83049D6FDF57D9C0C4EF6CC98739EFDBFC83B6536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfwaKBAd4IJXFGUIIbzM5gA= X-DA7885C5: 636BDD3628CFFAC3F255D290C0D534F97FA27D2DC697B1FCFDFBA4EA3BB55B4619F210DFA03D82F45B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2456271C549515A0025AB73F9DD1CFEA44CF5FC02694932AEEF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] dbg: fix DUALNUM detection for LLDB X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------SmUuBKiIyaPOzSDjKYwJvwWJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the fixes! LGTM Sergey On 6/5/26 19:01, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Added the separate commit as you suggested. > Branch is force-pushed. > > On 05.06.26, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! LGTM with a minor comment below. >> >> Sergey >> >> On 6/4/26 12:30, Sergey Kaplun wrote: >>> The `lj-arch` command on LLDB reports 'LJ_DUALNUM: True' for the >>> single-number build since the `module.FindSymbol()` returns an invalid >>> `SBSymbol` object [1], which is not `None`. This leads to invalid >>> DUALNUM mode detection. >>> >>> This patch fixes this by checking that the returned symbol is valid. >>> >>> [1]:https://lldb.llvm.org/python_api/lldb.SBModule.html#lldb.SBModule.FindSymbol >>> --- >>> src/luajit_dbg.py | 3 ++- >>> .../debug-extension-tests.py | 15 +++++++++++++-- >>> 2 files changed, 15 insertions(+), 3 deletions(-) >>> >>> diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py >>> index 410f0191..300d65e9 100644 >>> --- a/src/luajit_dbg.py >>> +++ b/src/luajit_dbg.py >> I believe DUALNUM should be added to the help for `lj-arch`. Now it >> describes only LJ_64, LJ_GC64: > I've added the separate commit for it. I'll send the patch in the reply > to the main thread. > > =================================================================== > dbg: update help for the lj-arch command > > This patch adds the description of the LJ_DUALNUM dumped flag to the > lj-arch command's help. > > diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py > index 60308179..3a3ca9b8 100644 > --- a/src/luajit_dbg.py > +++ b/src/luajit_dbg.py > @@ -1461,7 +1461,8 @@ lj-arch > > The command requires no args and dumps values of LJ_64 and LJ_GC64 > compile-time flags. These values define the sizes of host and GC > -pointers, respectively. > +pointers, respectively. Also, it dumps the value for the LJ_DUALNUM > +compile-time flag to inspect if LuaJIT is built in dual-number mode. > ''' > > def execute(self, arg): > =================================================================== > > > --------------SmUuBKiIyaPOzSDjKYwJvwWJ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the fixes! LGTM

Sergey

On 6/5/26 19:01, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Added the separate commit as you suggested.
Branch is force-pushed.

On 05.06.26, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch! LGTM with a minor comment below.

Sergey

On 6/4/26 12:30, Sergey Kaplun wrote:

The `lj-arch` command on LLDB reports 'LJ_DUALNUM: True' for the
single-number build since the `module.FindSymbol()` returns an invalid
`SBSymbol` object [1], which is not `None`. This leads to invalid
DUALNUM mode detection.

This patch fixes this by checking that the returned symbol is valid.

[1]:https://lldb.llvm.org/python_api/lldb.SBModule.html#lldb.SBModule.FindSymbol
---
  src/luajit_dbg.py                                 |  3 ++-
  .../debug-extension-tests.py                      | 15 +++++++++++++--
  2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py
index 410f0191..300d65e9 100644
--- a/src/luajit_dbg.py
+++ b/src/luajit_dbg.py

I believe DUALNUM should be added to the help for `lj-arch`. Now it 
describes only LJ_64, LJ_GC64:

I've added the separate commit for it. I'll send the patch in the reply
to the main thread.

===================================================================
dbg: update help for the lj-arch command

This patch adds the description of the LJ_DUALNUM dumped flag to the
lj-arch command's help.

diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py
index 60308179..3a3ca9b8 100644
--- a/src/luajit_dbg.py
+++ b/src/luajit_dbg.py
@@ -1461,7 +1461,8 @@ lj-arch
 
 The command requires no args and dumps values of LJ_64 and LJ_GC64
 compile-time flags. These values define the sizes of host and GC
-pointers, respectively.
+pointers, respectively. Also, it dumps the value for the LJ_DUALNUM
+compile-time flag to inspect if LuaJIT is built in dual-number mode.
     '''
 
     def execute(self, arg):
===================================================================

<snipped>
--------------SmUuBKiIyaPOzSDjKYwJvwWJ--