From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F054F42F4AD for ; Tue, 16 Jun 2020 00:20:18 +0300 (MSK) References: <20200611002510.35349-1-huston.mavr@gmail.com> From: Vladislav Shpilevoy Message-ID: <7855a532-9877-3fef-4a52-c480b4509e4a@tarantool.org> Date: Mon, 15 Jun 2020 23:20:16 +0200 MIME-Version: 1.0 In-Reply-To: <20200611002510.35349-1-huston.mavr@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] cmake: cleanup src/CMakeLists.txt List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: HustonMmmavr , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@gmail.com, avtikhon@tarantool.org, alexander.turenko@tarantool.org Hi! On 11/06/2020 02:25, HustonMmmavr wrote: > Removed definition and initialization of EXPORT_LIST variable at file > src/CMakeLists.txt. After patch 03790ac551 this variable is unused > (no reference to this variable after its initialization can be found > in whole project) and it is only misleading. Actually I am not sure it is not needed. Seems like purpose of this exporter was the same as for static libraries in a non-static build - not to allow to remove any public symbols of these libraries. Because linker can eliminate some parts of static libraries, if sees they are not used in the final executable. So probably EXPORT_LIST for static build should be exported just like exports.h, and it was missed in #2971. > Closes #5066 > --- > I've builded tarantool before applying this changes and after. > Then I've checked difference in tarantool binary file symbols with > nm and diff commands and there was no difference. Have you tried static build or normal build? Did you see the content of EXPORT_LIST, what is there? Isn't this related to https://github.com/tarantool/tarantool/issues/4559? > Issue: https://github.com/tarantool/tarantool/issues/5066 > Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5066-delete-unusued-export-list