From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BB76E4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 26 Apr 2020 20:47:26 +0300 (MSK)
References: <20200404095315.32905-1-olegrok@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <782c44c5-7cbc-b6e6-bce3-ceeda5840837@tarantool.org>
Date: Sun, 26 Apr 2020 19:47:24 +0200
MIME-Version: 1.0
In-Reply-To: <20200404095315.32905-1-olegrok@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] fio: provide access to
	stdin/stdout/stderr
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: olegrok@tarantool.org, imun@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

On 04/04/2020 11:53, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
> 
> This patch introduces fio API for interaction with
> stdin/stdout/stderr streams.
> 
> Closes #1338
> 
> @TarantoolBot document
> Title: fio provides access to stdin/stdout/stderr
> 
> Now access to standard streams is available via:
>   * fio.stdin
>   * fio.stdout
>   * fio.stderr
> 
> Each of this streams have usual fio file interface.
> 
> Example:
> ```lua
> fio.stdin:read(5) -- read 5 bytes from stdin

I tried these examples:

1. Start interactive console, call fio.stdin:read(5). When
I type any character, read() returns immediately, with 1
byte read. Not 5.

2. I tried starting Tarantool from a script, without the
console. In the script I did essentially the same - call
fio.stdin:read(5), print result, exit. It returned only
what I inserted until \n or 5 symbols, if I didn't print
\n.

Why?

> fio.stdout:write("Hello") -- write "Hello" to stdout
> fio.stderr:write("Error") -- write "Error" to stderr
> ```
> ---
> Issue: https://github.com/tarantool/tarantool/issues/1338
> Branch: https://github.com/tarantool/tarantool/tree/olegrok/1338-fio-std-streams
> 
> @ChangeLog
>   - fio provides access to stdin/stdout/stderr (gh-1338)
> 
>  src/lua/fio.lua       | 10 ++++++++++
>  test/app/fio.result   | 27 +++++++++++++++++++++++++++
>  test/app/fio.test.lua | 11 +++++++++++
>  3 files changed, 48 insertions(+)
> 
> diff --git a/src/lua/fio.lua b/src/lua/fio.lua
> index 83fddaa0a..1eaa085ae 100644
> --- a/src/lua/fio.lua
> +++ b/src/lua/fio.lua
> @@ -522,6 +528,10 @@ fio.utime = function(path, atime, mtime)
>      return internal.utime(path, atime, mtime)
>  end
>  
> +fio.stdin = ffi.new('struct fio_handle', filenos.STDIN)
> +fio.stdout = ffi.new('struct fio_handle', filenos.STDOUT)
> +fio.stderr = ffi.new('struct fio_handle', filenos.STDERR)

The problem is that when Tarantool will be terminated, Lua
is destroyed (probably it is disabled now, but I think will be
enabled at some day). Anyway, destruction of these handles leads
to closure of their descriptors, since fio handles now are
automatically closed when GC gets to them. That makes all printf(),
scanf(), fscanf(), etc, work with invalid descriptors, or even
already newly opened descriptors, not related to the standard
streams which took their place.

Better use dup() so as close of these descriptors wouldn't affect
other code.