From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6627770200; Sun, 31 Jan 2021 20:45:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6627770200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612115135; bh=HArE2QHW0Yjc82XsIPREp3llbb3x1pNpTLeYVsBcs0U=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Fh4z59roliHgTtbktXoPx65+egAUlOTDnxNIWQW/NM5J12ZpYo5vTY46MyHID+btC ejA0wPegicgcbhXs9HGgCdFGdBmHGKL2M7pPgPkgv217QKy+vDFs2nw3yAEWgDGc1l /OTDrcwk0qHwVn1O9GctkbykgoUMNJJMOBsinscc= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 296C170200 for ; Sun, 31 Jan 2021 20:45:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 296C170200 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l6Gmy-00070P-JH; Sun, 31 Jan 2021 20:45:33 +0300 To: Cyrill Gorcunov , tml References: <20210121171753.186891-1-gorcunov@gmail.com> <20210121171753.186891-3-gorcunov@gmail.com> Message-ID: <77f8143a-4a14-db54-c1a6-5f2909469be5@tarantool.org> Date: Sun, 31 Jan 2021 18:45:31 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210121171753.186891-3-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9CAEF2BF42A2A7729330F8028A4C0D8125182A05F538085040A76A729DA8D3764E99C60541864E940E3C1FC0690CC6D464EC28E03BEAE5B70F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE795306D5781316A8AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637993F4D0874F024C68638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6FC3BC18456BD4FD033E2AE831BEEE9AC8EE74BCAD719F4D389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C060F9ADC06DA375D58941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D6FBC3EC642A93BBCC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC47E915A23788DB9575ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E73564E4DC1543031AB7C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5D8832C42A3BAB84A01126757D6C7ECC03537C57808EAE36AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC223B6CC5B2DFAC18C0E899AC8385274F7FBA4F5952CC87915392BCAD6180C5DA770029F579C4041D7E09C32AA3244CD97B9D41E92F8EEF59A0030A4A2A80D63A92A9747B6CC886729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKiJYJ15DtLcnupXkZ0oNQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822E767A88220EA5BB43F59A2E3FD2BBC5E3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/3] box/info: report replication.X.downstream.lag value X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! It seems upstream.lag is documented. I suggest to document downstream.lag too. https://www.tarantool.io/en/doc/latest/book/replication/repl_monitoring/ > diff --git a/src/box/relay.cc b/src/box/relay.cc > index df04f8198..9265a26b3 100644 > --- a/src/box/relay.cc > +++ b/src/box/relay.cc > @@ -197,6 +205,7 @@ relay_new(struct replica *replica) > } > relay->replica = replica; > relay->last_row_time = ev_monotonic_now(loop()); > + relay->lag = 0; It is allocated with 'calloc', you don't need to nullify anything. > fiber_cond_create(&relay->reader_cond); > diag_create(&relay->diag); > stailq_create(&relay->pending_gc);