From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6D40A2BC7B for ; Sun, 28 Apr 2019 15:05:33 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AHacz0shKjV6 for ; Sun, 28 Apr 2019 15:05:33 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2A98E2BC1E for ; Sun, 28 Apr 2019 15:05:33 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/1] core: make tt_static buffers a singleton array References: <0739fcb1c2659e40eadc2ca9ad03c1d19954626f.1556309762.git.v.shpilevoy@tarantool.org> <20190427211153.GB5662@atlas> <554d070c-1a24-92a0-11e4-d20328692c5c@tarantool.org> <20190428183124.GD21439@atlas> From: Vladislav Shpilevoy Message-ID: <777f2c8f-e5cf-469f-4851-65c22ee09438@tarantool.org> Date: Sun, 28 Apr 2019 22:05:31 +0300 MIME-Version: 1.0 In-Reply-To: <20190428183124.GD21439@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov Cc: tarantool-patches@freelists.org Pushed to 2.1 and 1.10. On 28/04/2019 21:31, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/28 20:01]: >> I will not push this commit into the master, because it is >> fixed by the static memory allocator. See the new mail thread. >> >> Talking of 1.10 and 2.1 - I could push if you approve that the >> bug will be fixed differently in 1.10/2.1 vs the master. Not >> sure if we should push a new allocator into these branches. > > It's a bit annoying you don't push an approved patch :), OK, I > agree, please fix the bug in 1.10 and 2.1 and push the static > allocator to master. The static alloc patch is basically good to > go, I would get rid of tt_static.h altogether and move all these > utility functions to small, as a minor comment. > > I will reply to these patches separately. > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 >