From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F13946EC55; Fri, 8 Oct 2021 05:33:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F13946EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1633660421; bh=sDATn7GMxXJIh+iGjJNtASKEfpihrzIDEsNLX7MxTOQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IXOdy0EyFNQNWu6NNU4zE5/HWQAIWEClcK1pexKOgInMfgGgCj4al1UuuPxXula8v 1N/xPpPcand6FT08Soh1ns+r3Q4hEazZpd+l0icdXbIX1yusg4Z8TYYGYbSR09PHpq 0sTKhvkTURBeKVI2PSiTPJYpazRvNzkLG2fjahkM= Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EAB746EC55 for ; Fri, 8 Oct 2021 05:33:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EAB746EC55 Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1mYfhb-0008QJ-8d; Fri, 08 Oct 2021 05:33:39 +0300 To: Cyrill Gorcunov , tml Cc: Vladislav Shpilevoy References: <20211006201522.335898-1-gorcunov@gmail.com> <20211006201522.335898-3-gorcunov@gmail.com> Message-ID: <77769068-c0e9-6ab4-2df9-1f5b13829e15@tarantool.org> Date: Fri, 8 Oct 2021 05:33:38 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211006201522.335898-3-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A6D4E3B1981C4C7DC9765195527EE77661ADD44F6E79FA5A182A05F53808504034593D8B2D466D6E31E1706262CD664702E59DDB5E13F0C1B2FAB475384EF55E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE775E4C393EFDC22A2EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E8D1333770DC60CDEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2789846048A6561ABE203E71771D28E1CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637BA939FD1B3BAB99B389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D23BF7408B3F9022F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CE6BDB36F057AC83C2D242C3BD2E3F4C64AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3767A2104B63FB6E3BA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE79E9721B410A3B6ED731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D4502FC0A8F8DCC68C0B42CDBDAA0AF2C X-C1DE0DAB: 0D63561A33F958A58DA07156EE2B1CE3930D7660A5D85BB4300D67A1DCAAB6B7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759D2A03B9C34326B3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F0A5F58274334C95F53607BD58C38B63C83EA6B6DB7487BFCC3EDF500D69BEC9C16C88181130C3721D7E09C32AA3244CA2B9D8693F01914268B038FE307B3952D9ADFF0C0BDB8D1FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbhzlKa2eIcVi1smpX+j3ZQ== X-Mailru-Sender: 583F1D7ACE8F49BD8518EAAA0E4F94F1B4C692F234445D8B2A87920C4FDC52A391431A2EAE3E0579424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v20 2/3] qsync: order access to the limbo terms X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 06.10.2021 23:15, Cyrill Gorcunov пишет: > Limbo terms tracking is shared between appliers and when > one of appliers is waiting for write to complete inside > journal_write() routine, an other may need to access read > term value to figure out if promote request is valid to > apply. Due to cooperative multitasking access to the terms > is not consistent so we need to be sure that other fibers > read up to date terms (ie written to the WAL). > > Thanks for working on this! LGTM with one minor comment. ... > diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c > index 70447caaf..301fc1a8f 100644 > --- a/src/box/txn_limbo.c > +++ b/src/box/txn_limbo.c ... > @@ -724,11 +738,14 @@ txn_limbo_wait_empty(struct txn_limbo *limbo, double timeout) > } > > void > -txn_limbo_process(struct txn_limbo *limbo, const struct synchro_request *req) > +txn_limbo_process_core(struct txn_limbo *limbo, > + const struct synchro_request *req) > { > + assert(latch_is_locked(&limbo->promote_latch)); > + > uint64_t term = req->term; > uint32_t origin = req->origin_id; > - if (txn_limbo_replica_term(limbo, origin) < term) { > + if (vclock_get(&limbo->promote_term_map, origin) < (int64_t)term) { > vclock_follow(&limbo->promote_term_map, origin, term); > if (term > limbo->promote_greatest_term) > limbo->promote_greatest_term = term; > @@ -786,11 +803,33 @@ txn_limbo_process(struct txn_limbo *limbo, const struct synchro_request *req) > return; > } > > +void > +txn_limbo_process(struct txn_limbo *limbo, > + const struct synchro_request *req) > +{ > + txn_limbo_process_begin(limbo); > + txn_limbo_process_core(limbo, req); > + txn_limbo_process_commit(limbo); > +} > + > void > txn_limbo_on_parameters_change(struct txn_limbo *limbo) > { > if (rlist_empty(&limbo->queue)) > return; > + /* > + * In case if we're not current leader (ie not owning the > + * limbo) then we should not confirm anything, otherwise > + * we could reduce quorum number and start writing CONFIRM > + * while leader node carries own maybe bigger quorum value. > + */ > + if (!txn_limbo_is_owner(limbo, instance_id)) { > + say_warn("qsync: trying to change replication_synchro_quorum " > + "on node %u while owner is %u, ignore.", > + instance_id, limbo->owner_id); > + return; > + } Hm, I don't think we need a warning here. It'd be printed every time quorum is updated due to formula recalculations. > + > struct txn_limbo_entry *e; > int64_t confirm_lsn = -1; > rlist_foreach_entry(e, &limbo->queue, in_queue) { > ... -- Serge Petrenko