From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 22DCC29D67 for ; Wed, 27 Mar 2019 07:47:00 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id flOV4Ax-Ivfr for ; Wed, 27 Mar 2019 07:47:00 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CFC1329C65 for ; Wed, 27 Mar 2019 07:46:59 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: use 64b bitmasks instead of 32b where possible References: <84e81d55e8b11bc85fb9685df59548e2cc3feffb.1553085327.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: <772295c7-e691-05c4-ad72-ab3b8cb489e2@tarantool.org> Date: Wed, 27 Mar 2019 14:46:57 +0300 MIME-Version: 1.0 In-Reply-To: <84e81d55e8b11bc85fb9685df59548e2cc3feffb.1553085327.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org On 20/03/2019 15:36, Kirill Shcherbatov wrote: > In some cases(like foreign keys) the SQL code used > 32-bit bit mask, while 64-bit bit masks will perform better > column optimizations. There was refactored code to work with 64b > bitmasks where required. > The 32b bitmasks are still used to specify constant OP_Function > arguments because this change would require changing the P1 type > of the VDBE p1 argument, which is not desirable. Moreover, the > 64 function's arguments is an explicit overkill. > > The ticket was created in connection with the introduction of > foreign keys and their use of 32-bit bit masks. In the rest of > the scripts in SQL already use 64 bit masks, and the "smart" bit > of the mask is not applicable. > > Closes #3571 > > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3571-sql-column-mask-64 > Issue: https://github.com/tarantool/tarantool/issues/3571 > --- Please, put branch and issue links below that mark '---'. It is not a cavil or 'red tape'. It really affects things. For example, when somebody applies a patch from email, git can take these links as a part of commit message. LGTM.