From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E49486EC58; Wed, 4 Aug 2021 02:06:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E49486EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628032005; bh=L2L8jyI813+hC6glcYbAxZy7GAHW2CPiFbOspEjH1jY=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PUn9dWxqdTTgr3AcOXf7EpUjfzGKkHSWXVTMTD+doSDk1ahcynDstMxIR6P6jJvsJ bH62Cxo7dlPxDt6/AHMXKFgLeowzy/xO9qbhBhXynN9EUgce7fjlwJPSNYR8w6PdSe wSkJ7EQPk4w1oE2JgjGuwqucwwsUlzkhDXtM9amA= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BF5946F3E0 for ; Wed, 4 Aug 2021 02:06:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BF5946F3E0 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mB3UI-0005MM-ER; Wed, 04 Aug 2021 02:06:19 +0300 To: Vladimir Davydov , tarantool-patches@dev.tarantool.org References: <15f3d09cd20eb1b5b7e50f41925d8a51fb0f12a4.1627024646.git.vdavydov@tarantool.org> Message-ID: <770e8d26-401f-101c-4cce-905cb395dd27@tarantool.org> Date: Wed, 4 Aug 2021 01:06:17 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <15f3d09cd20eb1b5b7e50f41925d8a51fb0f12a4.1627024646.git.vdavydov@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C36A98DBA789EBB6AE26DB9A6C1D9BF7E0182A05F5380850405BF48BBAF08104694A012059D338B5EBF97A1B0889DCBC754D4F6A2807B95F4A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE763424119D34F5CBFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371005780D56A98C20EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F210D57553F2FFE9F612750F2F9F8FE46CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8BC0ADEB1C81BB362F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDCE939D40DBB93CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505E080CC72D5A361E39499F3C72095FB99 X-C1DE0DAB: 0D63561A33F958A5535D88C527E8005FDD89505BE37AFDE282CE54B1941735D1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3480665FBD8F49180C32D52C3B589D1C8B612E298B34D298A24396E6889EB73A3DD6EF0A6633B8A8AE1D7E09C32AA3244CA0A0DF2D3FF5EEDB5A52B6F568B61FA7A95CA90A1D8AC565729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojeDyvyeZJDJFyFCNzAhD3gA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DBA8548359FA4779194358E1E7CAF56243841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 16/20] net.box: store next_request_id in C code X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/lua/net_box.c b/src/box/lua/net_box.c > index 044f7d337ca7..1a615797d485 100644 > --- a/src/box/lua/net_box.c > +++ b/src/box/lua/net_box.c > @@ -79,6 +79,8 @@ enum netbox_method { > }; > > struct netbox_registry { > + /* Next request id. */ Should start with /**. After that LGTM. > + uint64_t next_sync; > /* sync -> netbox_request */ > struct mh_i64ptr_t *requests; > };