From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 17D205C0B79; Thu, 17 Aug 2023 14:06:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 17D205C0B79 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692270389; bh=6YRvz5zrHnK+8aL+Ad2bu+mhEO5At4sGwgQgTjRGHbo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EfRAs0zDxpbsNbQrqylvaYoOM2ZK4m0CUKUql4I1n/7N3jdXFmffEQt2mXiKofwmw YpCp4T7cFz2q/nkFI5vXXBcBfZHJWO0oaqj5oToxSjjt9zxY0AO4VyRAWf8db/ek7v 5MCIGFOUfC1VIe3X5D91mf3McC5GASGxmoqRIemQ= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EE842581FDB for ; Thu, 17 Aug 2023 14:06:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EE842581FDB Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1qWapf-003lR5-0N; Thu, 17 Aug 2023 14:06:27 +0300 Message-ID: <76c36c3b-fc98-4494-e275-f9a903fab61c@tarantool.org> Date: Thu, 17 Aug 2023 14:06:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin References: <37c2435a3529beb36c2e428f9c8e8b5c007c68e7.1691592488.git.skaplun@tarantool.org> In-Reply-To: <37c2435a3529beb36c2e428f9c8e8b5c007c68e7.1691592488.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D4FC677755C812E332EA741D6A7864909182A05F538085040A464FAB55A918B04544C47335C14D4AFD35497ECA4B8B8CC7E47324E069313A2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E16D8B060A9A23898638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EB5154692BCDC4ABC1324594A23626FB117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC7F48962964D238D0A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1A68A47777D5C6D9CD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD0E433DBF1FBFA39735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C3E97D2AE7161E217F089D37D7C0E48F6C8AA50765F79006373BA04B6A498D0BA4731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5077F111BFC42CA2DFBE60FC6C4F26819D532CED00A8A2ACDF87CCE6106E1FC07E67D4AC08A07B9B0E753FA5741D1AD02CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D346E67BC984B8ABCB58DB22474603FE92F8351C7DBA76ADD5155518C1E5CA01BE71CC9CA17CDC9C3BD1D7E09C32AA3244CE8AB1ED65FE43376B188B1436037AFE669B6CAE0477E908DBAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxq0cLAZ4dV4ww== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769483E5218C9531227544C47335C14D4AFB9A8FEFFB5F7F2D5EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 17/19] MIPS64: Fix register allocation in assembly of HREF. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! Test is passed after reverting the patch. On 8/9/23 18:36, Sergey Kaplun wrote: > From: Mike Pall > > Contributed by James Cowgill. > > (cherry-picked from commit 99cdfbf6a1e8856f64908072ef10443a7eab14f2) > > The issue is observed for the following merged IRs: > | p64 HREF 0001 "a" ; or other keys > | > p64 EQ 0002 [0x4002d0c528] ; nilnode > Sometimes, when we need to rematerialize a constant during evicting of > the register. So, the instruction related to constant rematerialization > is placed in the delay branch slot, which suppose to contain the loads > of trace exit number to the `$ra` register. The resulting assembly is > the following (for example): > | beq ra, r1, 0x400abee9b0 ->exit > | lui r1, 65531 ; delay slot without setting of the `ra` > This leading to the assertion failure during trace exit in > `lj_trace_exit()`, since a trace number is incorrect. > > This patch moves the constant register allocations above the main > instruction emitting code in `asm_href()`. > > Sergey Kaplun: > * added the description and the test for the problem Test is passed after reverting the patch. LuaJIT was built with and without GC64.