From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5759444643B
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 11 Oct 2020 18:26:01 +0300 (MSK)
References: <cover.1602420460.git.alexander.turenko@tarantool.org>
 <cb1f74efdf3ad671b20a6423db380f5c94d7a533.1602420460.git.alexander.turenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <76af18b8-e59f-025a-0d43-6f1df22fe78c@tarantool.org>
Date: Sun, 11 Oct 2020 17:25:59 +0200
MIME-Version: 1.0
In-Reply-To: <cb1f74efdf3ad671b20a6423db380f5c94d7a533.1602420460.git.alexander.turenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 11/15] module api: add
 box_key_def_dump_parts()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for the patch!

See 1 comment below.

> diff --git a/test/app-tap/module_api.c b/test/app-tap/module_api.c
> index 26853dd9b..25c98ef63 100644
> --- a/test/app-tap/module_api.c
> +++ b/test/app-tap/module_api.c
> @@ -602,6 +637,86 @@ test_key_def_new_v2(struct lua_State *L)
>  	return 1;
>  }
>  
> +/**
> + * Basic <test_key_def_dump_parts>() test.

test_key_def_dump_parts -> box_key_def_dump_parts.