From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D7F416F865; Thu, 29 Apr 2021 22:37:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D7F416F865 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619725079; bh=l2lgNWU9q8x9hIuWq++eVDZ6s+EFdGhVeRzyBzQNUpA=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rkvf9zPADwLNqdaBlO8WLGwbzaGXNkTnFpTs/dq15mamITDZUkMMcApVa0zPduKP9 e/8/0zXmu4xDiYoUS+uuZoXWetMeuSRVf5peAZooJTGxPP6Z7oj3aJj2XjXCAsVU6X ork2DXhaJKKQnefgdVHUNzudtPpwyn8GMPppnfso= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 766D76F865 for ; Thu, 29 Apr 2021 22:37:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 766D76F865 Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1lcCU1-0003g8-El; Thu, 29 Apr 2021 22:37:58 +0300 To: Cyrill Gorcunov References: <20210428102251.552976-1-gorcunov@gmail.com> <20210428102251.552976-3-gorcunov@gmail.com> Message-ID: <76ab28d4-6556-9368-7219-8dc0c40dccc4@tarantool.org> Date: Thu, 29 Apr 2021 21:37:56 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0B2C7F7C3B0039F139F0EF8E3717E163C182A05F538085040195F967149DF70DA5A785D547AC6BE4C5B05A121D0384E827EDE4727821099AD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7876E9C5582D2D91DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377E85B0EC44E8FD73EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA658EFF6699286E67F5993FCDB03C8E336E6F6B57BC7E64490618DEB871D839B73339E8FC8737B5C224905A8BD9291DE3CBBCC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0B272A53F9BBAC8E28941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B97735EF50AE51CB4CE9F57B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050FB28585415E75ADA9E7815D572A9D6896B3661434B16C20AC78D18283394535A9E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B96390DA516BDDC3475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C978314B935EEF8637C9E357D12FD7D753A721 X-C1DE0DAB: 0D63561A33F958A53174BA56F050FC1E93F4FAF716FED78905648F8127DA3FD2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F343DA43F62289FA7CF7D0602F30A4FC29EBFFD6301D2C5F963F7EEDEE2791C7A590CC4BD2764FB1D7E09C32AA3244CC12099F07EAFB50B31A8B0F0B7D4BC24250262A5EE9971B0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojVCmWsvwT1HZlumCSY1vxBg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA31103BEC40B2A51475B44D5143183B2F9ECF700A3768C868695507784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 2/2] fiber: fiber_join -- don't crash on misuse X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! > diff --git a/changelogs/unreleased/gh-6046-fiber-join-misuse.md b/changelogs/unreleased/gh-6046-fiber-join-misuse.md > new file mode 100644 > index 000000000..32c15566d > --- /dev/null > +++ b/changelogs/unreleased/gh-6046-fiber-join-misuse.md > @@ -0,0 +1,6 @@ > +## bugfix/core > + > +* Fixed lack of testing for non noinable fibers in `fiber_join()` call. > + This could lead to unpredictable results. Note the issue affects C > + level only, in Lua interface `fiber::join()`` the protection is fiber::join() -> fiber:join() And `` -> ` in the end.