From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C740925DC6 for ; Thu, 28 Jun 2018 11:48:00 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HPESHZu-cZFt for ; Thu, 28 Jun 2018 11:48:00 -0400 (EDT) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1BC0324E48 for ; Thu, 28 Jun 2018 11:48:00 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v3 00/10] sql: remove Triggers to server From: "n.pettik" In-Reply-To: Date: Thu, 28 Jun 2018 18:47:57 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <76AC7DC7-6F82-4C5B-BE84-9FE4D0B49CF7@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy , Kirill Shcherbatov LGTM as well. But patchset has exposed with two commits: first one simply consists of refactoring of functions in sql/trigger.c, renaming struct Trigger to struct sql_trigger and removing = SQLITE_OMIT_TRIGGER define guard. Second one removes global hash for triggers. IDK what our review policy says: should you look at them or not? > Now the patchset LGTM. >=20 > Nikita, please, review.