From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0CC93469710 for ; Mon, 25 May 2020 19:27:02 +0300 (MSK) References: <20200429122038.53296-1-arkholga@tarantool.org> <20200525130329.GI5455@tarantool.org> From: Olga Arkhangelskaia Message-ID: <76366f3a-19e4-f039-b84e-670e065d74a0@tarantool.org> Date: Mon, 25 May 2020 19:27:01 +0300 MIME-Version: 1.0 In-Reply-To: <20200525130329.GI5455@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance in postinstall List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Hi Igor! Have fixed commit message:  After tarantool installation on Debian/Ubuntu from repo, example instance  was automatically started on 3301 port. At the same time example instance  on RHEL/CentOS is started manually. Patch does the same for Debian/Ubuntu.   Closes #4507   @TarantoolBot document   Title: manage example instance after installation   After tarantool installation from repos on all distros example instance   should be managed manually.  @ChangeLog:   * Do not start example instance on 3301 port after tarantool installation   from Debian/Ubuntu repo. 25.05.2020 16:03, Igor Munkin пишет: > Olya, > > Thanks for the patch, LGTM except some nits regarding commit message. > However, it would be great to see a green full CI pipeline for such > changes especially Debian/Ubuntu packaging routines tests to confirm > nothing is broken after your change. Since this patch is trivial and > doesn't directly relate to package build process, I guess manual check > is enough. > > On 29.04.20, Olga Arkhangelskaia wrote: >> After taratool installation on Debuan/Ubuntu from repo, example instance > Typo: s/taratool/tarantool/. > Typo: s/Debuan/Debian/. > >> was automatically started over 3301 port. On the other hand example instance > Typo: s/over/on/. > Typo: s/On the other hand/At the same time/. > >> on RHEL/CentOS is started manually. Patch does the same for Debian/Ubuntu. >> >> Closes #4507 >> >> @TarantoolBot document >> Title: manage example instance after installation >> After tarantool installation from repos on all distros example instance >> should be managed manually. >> --- > Please provide a ChangeLog entry. > >> Branch: >> https://github.com/tarantool/tarantool/tree/gh-4507-disable-start-example-instance >> debian/tarantool-common.postinst | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/debian/tarantool-common.postinst b/debian/tarantool-common.postinst >> index e2eda3415..03e4b2215 100644 >> --- a/debian/tarantool-common.postinst >> +++ b/debian/tarantool-common.postinst >> @@ -22,14 +22,6 @@ case "$1" in >> install -d -o$SYSUSER -gadm -m2750 /var/log/tarantool >> install -d -o$SYSUSER -g$SYSUSER -m750 /var/run/tarantool >> install -d -o$SYSUSER -g$SYSUSER -m750 /var/lib/tarantool >> - >> - # Enable example.lua by default >> - if [ -z $2 ] && [ ! -e /etc/tarantool/instances.enabled/example.lua ] && >> - [ -d /etc/tarantool/instances.enabled ] && >> - [ -d /etc/tarantool/instances.available/ ]; then >> - ln -s /etc/tarantool/instances.available/example.lua \ >> - /etc/tarantool/instances.enabled/example.lua >> - fi >> ;; >> esac >> >> -- >> 2.20.1 (Apple Git-117) >>