From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D6218884A5D; Fri, 1 Dec 2023 17:22:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D6218884A5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701440571; bh=9zUmEP8ywkAF5MF51q7rBhhonb2v7bXXMg89Zy2pzs0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=D0g27pDk7vu9DeeqOeF0Fn6quK2tCjPPZEitN8JetmvZsxORZ+F0E+XlvDPF13yqN MkSBBUMAVE2YdCmAMeESEsVSxKLHwoST/pdrUZ4nYG3tO59o2bgrRaYO6Aw8lI5x4H hwTFaMp13IH7Z/sjolxYA3fxSs5muzwA51KCmZ9w= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AB52C709E04 for ; Fri, 1 Dec 2023 17:22:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AB52C709E04 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1r94Po-00Ae8N-1e; Fri, 01 Dec 2023 17:22:48 +0300 Message-ID: <7588c0b0-cbf3-4054-b28c-f30ee5361078@tarantool.org> Date: Fri, 1 Dec 2023 17:22:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun References: <20231114150455.2850-1-skaplun@tarantool.org> <47007825-9906-4f23-b719-79d822672e32@tarantool.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91486559A3ABF84E7CB0A098B493E0346EE397C45C3170F78182A05F538085040002EB50A796BA4E2A4690913D0135446BEF87DBA5FFC1D5734540806AA08C8C3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AB5815F4DE05345AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DB576DCB83B448D28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8FD48D339C87E13F3BB34BAE240AE8DA8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B128F6BDBBAB179F4ED8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F254576263B31EA9C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FC0F9454058DFE53C35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A592E0AF6F30F6B027A3BB59996DDD72DA7FFD362CAC26E3F2F87CCE6106E1FC07E67D4AC08A07B9B01E44367C8E80A7B4CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3455AC8BF8E3153BA0A41E287A8275D34EC6B4AF2AF68F74F8B0CE5BDE6DFEE25249F6E10CAF78CB9F1D7E09C32AA3244C5B6EF54394FE93841853465C8102D205A995755A1445935E85A42E4C463514DC5DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5JGy3/nQ2fj/jlVdosb8nQ== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769B580A10074FFED37A4690913D01354461E1E156D000DABDBEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for BUFHDR append. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks! LGTM On 11/27/23 13:38, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for review! > Fixed your comment, rebased on the current master and force-pushed the > branch. > > On 24.11.23, Sergey Bronnikov wrote: >> Hello, Sergey >> >> thanks for the patch! LGTM with a nit below. >> >> On 11/14/23 18:04, Sergey Kaplun wrote: > > >>> +-- The instruction to be folded is the following: >>> +-- 0016 p32 BUFPUT 0015 0011 >>> +-- >>> +-- The 0011 operand is PHI, which is not the last IR in the BUFSTR >>> +-- chain (`ir->prev = REF_BIAS + 0006`). Folding this IR leads to >>> +-- this resulting IR: >>> +-- p32 BUFHDR 0010 APPEND >>> +-- Which appends to buffer instead of reseting, so the resulting >> After rebase on tarantool/master and running LuaJIT-codespell: >> >> reseting ==> resetting > Thanks, fixed! > > =================================================================== > diff --git a/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua > index 19be91a4..98b83ece 100644 > --- a/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua > +++ b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua > @@ -35,7 +35,7 @@ jit.opt.start('hotloop=1') > -- chain (`ir->prev = REF_BIAS + 0006`). Folding this IR leads to > -- this resulting IR: > -- p32 BUFHDR 0010 APPEND > --- Which appends to buffer instead of reseting, so the resulting > +-- Which appends to buffer instead of resetting, so the resulting > -- string contains one more symbol. > > -- XXX: Use 5 iterations to run the variant part of the loop. > =================================================================== > >>> +-- string contains one more symbol. > >