From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roman.habibov@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CC64D469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  8 Oct 2020 18:33:54 +0300 (MSK)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
From: Roman Khabibov <roman.habibov@tarantool.org>
In-Reply-To: <04312961-1242-50a0-de21-dac394f979ef@tarantool.org>
Date: Thu, 8 Oct 2020 18:33:50 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <75715DF2-8E60-4117-91F4-88C120DE3494@tarantool.org>
References: <20200911222203.12336-1-roman.habibov@tarantool.org>
 <04312961-1242-50a0-de21-dac394f979ef@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: add missed
	sqlReleaseTempRange()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hi! Thanks! Nikita, can you see the patch?
=
https://github.com/tarantool/tarantool/tree/romanhabibov/release-temp-reg

> On Sep 17, 2020, at 17:27, Vladislav Shpilevoy =
<v.shpilevoy@tarantool.org> wrote:
>=20
> Hi! Thanks for the patch!
>=20
> LGTM.

commit 6eccc4f0b3d107d5963ea10e391ef8924cac381f (HEAD -> =
romanhabibov/release-temp-reg, origin/romanhabibov/release-temp-reg)
Author: Roman Khabibov <roman.habibov@tarantool.org>
Date:   Sat Sep 12 01:05:29 2020 +0300

    sql: add missed sqlReleaseTempRange()
   =20
    Clean up temp registers with sqlReleaseTempRange() during check
    constraint alter.

diff --git a/src/box/sql/alter.c b/src/box/sql/alter.c
index 14f6c1a97..4874b46c9 100644
--- a/src/box/sql/alter.c
+++ b/src/box/sql/alter.c
@@ -136,6 +136,7 @@ sql_alter_ck_constraint_enable(struct Parse *parse)
 		      tuple_reg + field_count);
 	sqlVdbeAddOp4(v, OP_IdxReplace, tuple_reg + field_count, 0, 0,
 		      (char *)ck_space, P4_SPACEPTR);
+	sqlReleaseTempRange(parse, tuple_reg, field_count + 1);
 exit_alter_ck_constraint:
 	sqlDbFree(db, constraint_name);
 	sqlSrcListDelete(db, src_tab);