From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A1590267EE for ; Thu, 12 Jul 2018 06:28:39 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dXV8QxufRYWw for ; Thu, 12 Jul 2018 06:28:39 -0400 (EDT) Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 614FD267AD for ; Thu, 12 Jul 2018 06:28:39 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: fix assertion on invalid PK column name References: <1741e4e16438af3e3cb88ecd84a64faf711ad661.1531376946.git.kshcherbatov@tarantool.org> <40d06911-2dbc-69e0-24b3-fb1a70cc33af@tarantool.org> From: Vladislav Shpilevoy Message-ID: <751beb51-7b17-8566-a3c7-761e01015293@tarantool.org> Date: Thu, 12 Jul 2018 13:28:36 +0300 MIME-Version: 1.0 In-Reply-To: <40d06911-2dbc-69e0-24b3-fb1a70cc33af@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org LGTM. On 12/07/2018 13:03, Kirill Shcherbatov wrote: >> I know, that removal of assertion always 'fixes' it, but please, >> either fix it without removal (and for me it is not obvious why it >> should be removed), or explain, why it is invalid. > I've included this assertion during refactoring and there is no root causes to > keep it, but as we verbally discuss, let's make it working correctly appending > additional pCol == NULL OR condition that code below correctly deal with. > > ======================================== > > If specified PK column modifier refers nonexistent column, > lookup by name keeps NULL column pointer unchanged that should > be accounted in assert. > > Close #3522. > --- > https://github.com/tarantool/tarantool/compare/kshch/gh-3522-invalid-primary-key-column-name > https://github.com/tarantool/tarantool/issues/3522 >