From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9390C96D1E1; Tue, 16 Jan 2024 12:47:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9390C96D1E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1705398451; bh=KMGo6VVGayS4BrswbmShnjZk02Pxk2pG6T9Zgt1LYN0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WFaSpddEERGkInu9TpX/j9REaIOMqgmg6Jy0BUqrYLJNr1pLW/brrVXCDaKDJYtwy dWw4WyIi7Et+xLcHj//EuKojxHwAyXIKz+iar0lTo8Kp9ziIGozQJSLk2CvOpw78f6 A5tk6QbccMu9dz5/W7ijCyAA1kDNOWGgQMK1F2u0= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [95.163.41.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1913296D1E1 for ; Tue, 16 Jan 2024 12:47:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1913296D1E1 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1rPg2b-0068W9-14; Tue, 16 Jan 2024 12:47:29 +0300 Message-ID: <74ddf2d3-e2c7-4ef7-a932-a8df2a487353@tarantool.org> Date: Tue, 16 Jan 2024 12:47:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin References: <20231211112657.19060-1-max.kokryashkin@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9AE5B4AFB3AE2A590E10A57BB36FAC7D4F681D642268DCBB5182A05F538085040EC36BBC566A33A1FBAA14660C4F6EBA9535D994DE0AB441FBEC6122AC70ACCBF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E6006D770ADD73CF8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8ADC46F1B0374469380E203FF2E078976117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B107FB45A5F6E725C8D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3632EDEA9CD5989A39735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C1D471462564A2E192E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F0A35B161A8BF67C1C6EABA9B74D0DA47B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A558F96025D80A4CADD710D43003F12D6DC6EC20BF4CFA3F44F87CCE6106E1FC07E67D4AC08A07B9B064E7220B7C550592CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34E20F2278F74481A1739B935C989EF74276B457E0499CB87E02E34446B694AC40CB2CB579B4F4CB651D7E09C32AA3244C97C1528C0BCD268B20D67251338217237101BF96129E4011BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioji89z+8RvaBPQMS17CMajMg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769ABA4E855CD487F26BAA14660C4F6EBA9816609AA8FC7A761EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Allow building with unwinding disabled. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max,  thanks for correction! LGTM as I said before On 1/9/24 17:18, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the review! > On Fri, Dec 29, 2023 at 04:40:23PM +0300, Sergey Bronnikov wrote: >> Hello, Max! >> >> thanks for the patch! LGTM with a minor comment >> >> On 12/11/23 14:26, Maksim Kokryashkin wrote: >>> From: Mike Pall >>> >>> (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16) >>> >>> Prior to this patch, the LuaJIT build with the >>> `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of >>> linker relocation errors related to dwarf-specific code. This >> probably it is worth adding an error message produced by linker. >> >> Feel free to ignore. > Added. Here is the new commit message: > === > ARM64: Allow building with unwinding disabled. > > (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16) > > Prior to this patch, the LuaJIT build with the > `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of > linker relocation error related to dwarf-specific code: > | /usr/bin/ld: lj_vm_dyn.o: relocation R_AARCH64_PREL32 against > | symbol `lj_err_unwind_dwarf' which may bind externally can not > | be used when making a shared object; recompile with -fPIC > | lj_vm_dyn.o:(.eh_frame+0x12): dangerous relocation: unsupported > | relocation > > This patch disables emission of the `.eh_frame` section for > builds without unwinding to solve the issue. > > The `LUAJIT_NO_UNWIND` build option is added to CMakeLists.txt. > This patch adds this build flavor to our exotic builds workflow. > > Maxim Kokryashkin: > * added the description for the problem > > Part of tarantool/tarantool#9145 > === >> >> >>