From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 79415C5B3C2; Thu, 22 Aug 2024 18:04:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 79415C5B3C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724339070; bh=KR9QJbnSVVEVkVegHZYDlDbo+8rg5q7XFfu9H6zT2IQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=g17tyhalhvPzhNoCqMIXLUBJHNeMZ+WB7GgZp7gtfjuhPqFl+BLB5MSASnv4KlnFz t36XXneXS64KfGOtfIiMecfyT4uFQd1ATSeLL8ZZnnPMahAr5/36HGbfCC6YQ0GDwW hTQkEgXncBI7oWj92d1k25s2SAmIcrYD+Pz3hvQ4= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 77A99C5B3C1 for ; Thu, 22 Aug 2024 18:04:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 77A99C5B3C1 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1sh9MS-00000009Sy7-0lfd; Thu, 22 Aug 2024 18:04:28 +0300 Content-Type: multipart/alternative; boundary="------------T7yDuXfcVfPf71FL4uIIhTFh" Message-ID: <74b9d8c7-f2f0-45fe-9a47-e5b01c2ea976@tarantool.org> Date: Thu, 22 Aug 2024 18:04:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <1c96fa3b26cf05abef360b674d241f5c2a2208ca.1724228998.git.skaplun@tarantool.org> <49236ef7-cc89-4508-b6f8-d79c20ff24b1@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E80479E83A5F5ECBCB411FF80AE7BBDAB182A05F5380850409D4EB610B76A673D5D1BE6A8D71B10A5FCC42FC196B1DDBDEDDFFFF196D306A5467020CA3B4CCCD9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70CB15FA6C489297DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8845A113637A41A31EAB85FC927F4456A28DD68229C6C55F9CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637B2737265289038E2D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C0500AC0B2F9B62304B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B8E48D8FAA4D20A9F75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5E72454E9749DCFE95002B1117B3ED696B2CA214EAD737A1D0E58516B1639A14B823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D346F44602F3B4946348B471786CE009A9356A383EE880E4CDF1D352E2776A14FE8625BF91D5CE630E41D7E09C32AA3244C09F43B69A7E4A290E70D6F05539DA95A909DFDE478BF9624EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XpSP79QeTVY3w== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61405E9998948EF8E62998AEBA97E5AC0C000885611C9932C8FD0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/45] test: remove LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------T7yDuXfcVfPf71FL4uIIhTFh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.08.2024 19:36, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answers below. > > On 21.08.24, Sergey Bronnikov wrote: >> Sergey, >> >> thanks for the patch! >> >> On 21.08.2024 11:58, Sergey Kaplun wrote: >>> This patch removes the aforementioned test since it is identical to the >> Line's width is 70 symbols, please split. > The maximum line's width is 72 symbols, see [1]. It is 71 here, so > ignoring. > > Side note: I use (if not forgot) the Vim auto-formatting for the gitcommit. > For the code style, it needs some tuning and configuration. > :help v_gq > Thanks! LGTM >> LGTM >> >>> test, which wasn't cleaned up during the >>> refactoring in the original repository. >>> >>> Part of tarantool/tarantool#9398 >>> --- >> > [1]:https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message > --------------T7yDuXfcVfPf71FL4uIIhTFh Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 21.08.2024 19:36, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Please consider my answers below.

On 21.08.24, Sergey Bronnikov wrote:

Sergey,

thanks for the patch!

On 21.08.2024 11:58, Sergey Kaplun wrote:

This patch removes the aforementioned test since it is identical to the

Line's width is 70 symbols, please split.

The maximum line's width is 72 symbols, see [1]. It is 71 here, so
ignoring.

Side note: I use (if not forgot) the Vim auto-formatting for the gitcommit.
For the code style, it needs some tuning and configuration.
:help v_gq
Thanks! LGTM
LGTM


<lib/coroutine/yield.lua> test, which wasn't cleaned up during the
refactoring in the original repository.

Part of tarantool/tarantool#9398
---

<snipped>

[1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
--------------T7yDuXfcVfPf71FL4uIIhTFh--